Notepad3: Dropping block/rectangle selection shuffles characters

[McLoo]

Just tested drag to scroll in 5.20.225.3 and noticed, that the dropping of block selections result in a single line with shuffeld characters. This is also the case in 5.20.221.1. But not in 5.19.815.2595
Fails one with one liners even

Block select

Notepad3

drag somewhere to get

N3dapeto

or

rizonesoft
Notepad3

to

r3dapetotfosenozi
N

[RaiKoHoff]

Yes indeed, drag&drop a rectangular selection does not work as expected (like cut&paste).
Seems to be a Scintilla upstream problem, even with the patch supplied by Neil Hodgson.

[McLoo]

Not completely sure if it's an upstream issue:
Scite 4.3 has no issue with rectangular selection.
Notepad3 behaves like this since 5.20.103.2997 (didn't check farther back)
Notepad3 5.19.815.2595 behaves fine :)

[RaiKoHoff]

@McLoo : Thank you for analysis. Very strange... 🤔 - still debugging ...

[hpwamr]

Notepad3 behaves like this since 5.20.103.2997 (didn't check farther back)

_Edited to add missing link:_
Hello @McLoo ,
FYI, I've just placed in #1129 (at the end), the Notepad3 Betas 2019 (285 MB): "BetaBuild_until_release_5.20.xxx.xxxx_(2019).7z or from site_2".

Sorry, I can search for myself because I am abroad with limited internet and computer access... :worried:

[RaiKoHoff]

@hpwamr : Unfortunately we have a gap in our beta archive (15th Aug 2019 - 3rd Jan 2020) 😲, where this issue has been introduced ???

[hpwamr]

Unfortunately we have a gap in our beta archive (15th Aug 2019 - 3rd Jan 2020) astonished, where this issue has been introduced ???

Hello @RaiKoHoff ,
No my friend, this file (285 MB) contains all Betas for this period: BetaBuild_until_release_5.20.xxx.xxxx_(2019).7z or from site_2

[McLoo]

Notepad3Portable_5.19.902.2614 Rectangle OK
Notepad3Portable_5.19.902.2615 broken build
Notepad3Portable_5.19.903.2616 broken build
Notepad3Portable_5.19.904.2617 Rectangle messed up

[RaiKoHoff]

@McLoo: Thank you for analysis - that helped me much 😀

Feel free to test the RC2 prototype version "Notepad3Portable_5.20.227.4_RC2.paf.exe.7z" or higher.
See "Notepad3 BETA-channel access issue #1129" or here Notepad3Portable_5.20.227.4_RC2.paf.exe.7z.

Note: "Notepad3Portable RC2" can be used in "2 flavors" (with or without the extension ".7z").

Your comments and suggestions are welcome... 😃

[McLoo]

Dragndrop with rectangular selection works fine for me now. Also the paint-lock fix :)

What I noticed with rectangular selection (if not related, i'll open another issue):
Pasting a copied rectangular selection is slow. Feels like ~0.5 seconds. Wheras duplicating the block with CTRL+D feels instant.

Tried the same in Scite. No delay recognizable.

Tested with the following sample. Selection like shown in the screenshot.
With this selection CTRL+D or CTRL+C CTRL+V

bbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbb 
bbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbb 
ccccccccccccccccc ccccccccccccccccc 
aaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaa 
bbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbb 
ccccccccccccccccc ccccccccccccccccc 
aaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaa 
bbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbb 
ccccccccccccccccc ccccccccccccccccc 
aaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaa 
bbbbbbbbbbbbbbbbb bbbbbbbbbbbbbbbbb 
ccccccccccccccccc ccccccccccccccccc 

[RaiKoHoff]

@McLoo : Yes, that right.
The rectangular selection is dropped into the text by inserting character by character (Scintilla).
For each char insertion, Notepad3's main loop is triggered (notify change).
For a NotifyChange event, I have 2 different loops: a "fat" one, which updates all expensive things (Status Bar, Tool Bar, Hyperlink detection, Occurrence Counter, Indicators, etc.) and a "lean" one, which only updates the absolutely necessary stuff (and delays the "fat" run until multi-op task has finished). For most multi-op tasks, I can delegate the change notification to the "lean" one (changing/inserting multiple chars/lines ...).
Unfortunately, I have currently no hint (yet) for that drag&drop stuff, cause it is completely handled Scintilla internally and I see only char insertion notify change events as if they were typed by the user ... 🤔