Trenchbroom: Heretic II Valve 220 support

[whirledtsar]

I modified TB's Ht2 gameconfig to include the 220 format. While creating a test map, I found that surface/content flags do not show up in the compiled map, and are forgotten when the map is reloaded in TB. This appears to be the same issue as https://github.com/TrenchBroom/TrenchBroom/issues/2840, but in Heretic II.

[ericwa]

It's working on TB from master if I do this:

{
    "version": 4,
    "name": "Heretic 2",
    "icon": "Icon.png",
    "fileformats": [ 
        { "format": "Quake2" },
        { "format": "Quake2 (Valve)"}
    ],

I guess we should include Valve in the bundled config?

[whirledtsar]

In my TB (2020.1), the gameconfig gives Ht2 "version": 3, and changing it to 4 results in an error.
But anyways, it does seem that Qbism's 220 tools work with HT2, so it couldnt hurt.

[ericwa]

Ah sorry, you can ignore the "version":4, that's for 2020.2 (unreleased yet).

The { "format": "Quake2 (Valve)"} bit should work on 2020.1 though, as we included Q2 Valve220 support in 2020.1, I think.

But anyways, it does seem that Qbism's 220 tools work with HT2, so it couldnt hurt.

sounds good, I'll add it

[whirledtsar]

Sorry for confusion but has the problem of surface/content flags being forgotten been solved? It just works in dev builds?

[ericwa]

It's working for me in dev builds as well as 2020.1, once I added { "format": "Quake2 (Valve)"} to the heretic 2 game config.

All that I tested was assigning the "trans33" flag to a face, but it loads and saves fine:
htic2test.map.txt

[whirledtsar]

This issue is still occurring in 2020.2 RC2. Surface and content flags are forgotten after closing and re-loading the map.
tst220.map.txt

[ericwa]

@whirledtsar the problem is your map is set to "Valve" format, which TB understands as "Quake 1, so no surface flags/contents"

If you change the first 2 lines to:

// Game: Heretic 2
// Format: Quake2 (Valve)

it will work.