Trenchbroom: Items using 'angles' key don't reflect in-game rotation

[dumptruckDS]

Setting the 'angles' key and x y and z coordinates will rotate an entity in-game. e.g. health pickup

TB currently does not apply rotation if the bounding box is not centered.

[kduske]

I think I remember this to be a conscious decision. @ericwa do you remember? I‘m sure we talked about this.

[ericwa]

There is some discussion in https://github.com/kduske/TrenchBroom/issues/917
and https://github.com/kduske/TrenchBroom/issues/642

I haven't read it all but this still seems like a legitimate bug to me, not sure why the origin being in the centre of the bbox should matter

[Omeganinjaboy]

I had the same problem with angles and mangle. The editor representation is far off of in-game representation. For example, I am making a dome roof that retracts at a 45 degree angle downwards. The editor reflect this, but in-game they seem to go wherever they want. I can't seem to find a pattern between the in-editor and in-game representations to be able to compensate. I could post a video so that you can better find the problem. I could set several doors to different angles, each having only one variable in the angles function changed. Then, one could see how off it is and how those changes are reflected in the game relative to the editor. If you can't show proper representation for brush entities because it would mess up representation in another type of entity. You could have the editor change the way it displays the angle based on the type of entity it is (have a different bit of code for some entities than others).

[ericwa]

Was looking at this again.

Issues:

• [x] Mangle is only "yaw pitch roll" in the context of the light tool, AFAIK. In other contexts in Quake it's copied into the .angles field by QC code and is then "pitch yaw roll" (info_intermission, misc_model in mods like quoth, copper, AD1.8)
• [x] The negative pitch is specific to .mdl models, other model types like .bsp shouldn't do it
• [x] TB has the protection against the rotate tool / Alt+arrow commands rotating entities whose origin is not at the bounds center. The intention was to protect Quake mappers from rotating models away from their collision volumes, which don't rotate in Quake (afaik). We should at least render these cases as they are in game if they have a mangle/angles manually set on them.
• [x] Picking bugs with BSP29 models in my test map
• [ ] Quoth's mapobject_custom origin wobbles around when rotating using the rotate tool. Origin should not change when rotating a point entity with the rotate tool. The exception is misc_explobox type cases (origin is in one corner of the bbox), so TB will avoid applying rotations and instead will move the origin to keep the bbox the same. - This was caused by the rotation center grid snapping. I guess it's by design, it's a separate discussion I guess but I think it's undesirable at least when the selection is a point entity, and maybe in all cases.

[kduske]

The intention was to protect Quake mappers from rotating models away from their collision volumes, which don't rotate in Quake (afaik).

Yes, it was.

We should at least render these cases as they are in game if they have a mangle/angles manually set on them.

I agree.