Teammates: AccountAttributes: Add test cases for builder

Created on 21 Feb 2018 · 9Comments · Source: TEAMMATES/teammates

We recently added a builder for AccountAttributes (#8382) but the added builder class isn't covered by tests (see StudentProfileAttributesTest for examples of possible unit tests). We should add tests to ensure that construction works.

a-Testing good first issue p.Low

Source

craaaa

Most helpful comment

Here is a list of few tests done for builder pattern which can be used for reference.

Although the tests will be very similar to the ones above. In AccountAttributes, the .build() sanitizes all data members, which is something that would need to be taken care of while doing assertion checks

https://github.com/TEAMMATES/teammates/blob/d55382c0bf2720ee77dc96f5cb7c079884afb915/src/main/java/teammates/common/datatransfer/attributes/AccountAttributes.java#L110-L120

tshradheya on 21 Feb 2018

👍2

All 9 comments

If you aren't working on this already, I can take it up since I had worked on #8382 to add a builder pattern for AccountAttributes

tshradheya on 21 Feb 2018

If you aren't working on this already, I can take it up since I had worked on #8382 to add a builder pattern for AccountAttributes

Is this suitable for new contributors? If so, you can review the PR when it comes in.

damithc on 21 Feb 2018

Is this suitable for new contributors?

Should be suitable considering they can have a look at tests of other builder patterns used, for e.g. CourseAttributes , StudentProfileAttributes and get a good idea of what to do.