Teammates: User map: move 'last updated date' to userMapData.json

[damithc]

Currently the last updated date of the user map is in src/main/webapp/usermap.jsp while the user data is actually updated in src/main/webapp/js/userMapData.json.

Explore the possibility of moving the date into the json file so that only one file needs to be updated.

[AnaghHegde]

@damithc i am interested in this. can i work on this ?

[damithc]

@AnaghHegde sure

[AnaghHegde]

@damithc can you guide me a little about the issue. I didn't get the issue properly.

[damithc]

@AnaghHegde Have a look at #5792 That should help you understand what this issue is about.

[AnaghHegde]

@damithc one more thing just to confirm its with respect to only user map right?

[damithc]

one more thing just to confirm its with respect to only user map right?

Yes.

[AnaghHegde]

@damithc Correct me if i am wrong ok but in the issue #5792 the date is updated no?. So i just have to again update it for latest user map right ?.

add : should i have to put the date as : 30 November 2016 ?

[damithc]

but in the issue #5792 the date is updated no?. So i just have to again update it for latest user map right?

No, you misunderstood the issue entirely. Give it another go (i.e read the issue description again and give it some more thoughts). :-p

[AnaghHegde]

@damithc ok. So i have to move (add in json file ) the last updated date to userMapData.json and make it display in the webpage right? and remove the last updated date in usermap.jsp file ?

[damithc]

So i have to move (add in json file ) the last updated date to userMapData.json and make it display in the webpage right? and remove the last updated date in usermap.jsp file ?

Yes, that's right.

[paradite]

I think this is actually quite hard to do. The approach I can think of is to:

• fetch the data from json using javascript
• render it within the jsp using javascript

Edit: Never mind, I see that there are already some js code within the jsp that reads from the json. (Ironically it was me who wrote the first version of those js code and I forgot about them)

[AnaghHegde]

@paradite Thanks for the input.

[AnaghHegde]

@damithc can you please help me in #6322 .Its failing in code formats even though i did the source format.

[paradite]

https://github.com/TEAMMATES/teammates/issues/6317#issuecomment-271586376

testing.

[AnaghHegde]

@paradite I didn't get you.

[paradite]

@AnaghHegde Ah sorry. I was just testing out something It is not related to you or the issue, you can ignore it.

[AnaghHegde]

@damithc Can you please tell me what does this error says : Unexpected negated condition no-negated-condition . I got this in build log.

[damithc]

Can you please tell me what does this error says : Unexpected negated condition no-negated-condition . I got this in build log.

Let's see what happens after redoing your PR from scratch after a fresh setup.

[AnaghHegde]

I did from the scratch and this is the only error i am getting.So i am
asking this.

On Fri, Jan 13, 2017 at 8:55 AM, Damith C. Rajapakse <
[email protected]> wrote:

Can you please tell me what does this error says : Unexpected negated
condition no-negated-condition . I got this in build log.

Let's see what happens after redoing your PR from scratch after a fresh
setup.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TEAMMATES/teammates/issues/6317#issuecomment-272351691,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALcwr4atIoaMveGkrXc6nud4n7Rla3Z5ks5rRu6TgaJpZM4LfSy5
.