Teammates: New contributor self intro Shubham Garg

[shubham49]

a) Link to my app: https://teammates-shubham49.appspot.com/
b) Link to fork: https://github.com/shubham49/teammates
c) I changes the title to "TEAMMATES (HOME) - Online Peer Feedback/Evaluation System for Student Team Projects" and changed image in the center.

d) My name is Shubham Garg. I am a final year student at GNDU. I have made some college projects on Spring, struts, hibernate. I wanted to learn more frameworks and technologies. I never got the opportunity to work with professionals, so I want to learn from them for my personal growth.

[VamsiSangam]

Hi @shubham49 ! Welcome to TEAMMATES! :smile:

Looks like you deployed the application perfectly! But you were expected to do your modifications in a new branch named tinker, not in your master branch. You might have missed the Phase C in contributor's orientation guide. Please revert the code in the master branch.

Don't worry, take your time to make the changes. Setting up the project is a crucial step. Feel free to comment here if you are stuck at anything. :smile:

[shubham49]

Hi @VamsiSangam Thanks for the help. Actually I am new to git so not very familiar with git commands.
I have made appropriate changes at my repository.

[VamsiSangam]

@shubham49 , you manually removed all the changes. That is not what I meant by revert. Your master branch is still 2 commits ahead of TEAMMATES:master. I understand you are new to git. So don't hesitate/feel shy to ask for help here. We all came here to learn. :wink:

Have a look at this. Instead of removing 1 commit, you simply need to remove 2.

[VamsiSangam]

In the end your branch should display a message as such -

Let me know if you have any trouble. :smile:

[shubham49]

I did everything from eclipse. In the history tab I see two extra commits that need to be deleted.
But there is not option of re-basing master to older revision.

Through command line I get status "fatal: your current branch 'master' does not have any commits yet"

[VamsiSangam]

It is generally not recommended to use the IDE to do git stuff. Most programmers prefer using the command line. So let us keep Eclipse out of this :stuck_out_tongue_closed_eyes:

Can you paste the list of commands you executed and their output here so that I can assist you better?

[shubham49]

[VamsiSangam]

It is a little unusual that you don't have an origin. Ideally, on typing git remote -v you should get a result like this -

I think you might have set up the project a little differently than what's mentioned in the docs. Please start again freshly. Don't feel bad that I'm asking you to set up the project again :sweat_smile: This is a one-time effort, and it ensures that future development won't be messy. I will guide you through the steps.

Please follow the documentation strictly, and if you have any doubts regarding git commands, please ask here.

So, according to setUp.md, I assume you have completed Step 1. Now in Step 2, you have already forked our teammates repo. Now you already have a copy of the teammates project in GitHub. To get a copy on your PC, type the command -

git clone https://github.com/shubham49/teammates.git

Then add a new remote upstream by following 2nd point in Step 2 of setUp.md. As a part of verification, please post the output of git remote -v here, after you complete this step.

After setting upstream, follow 3rd point in Step 2 of setUp.md. Now, open this fresh project in your PC, in Eclipse. Follow the settings in the docs exactly as given. Let me know if you have any issues.

[shubham49]

I have followed above instructions and reverted my master branch. Now I want to create branch tinker and commit changes through command line. Earlier I did that with eclipse Egit. Please share some resources to make new branch (or to work with branches) and commit selected files to that (as there would be a lot uncommitted files).

[VamsiSangam]

Nice work so far! :+1: Check this link for info about branches. To create a new branch you would do -

git branch tinker

But remember, doing that does not take you to tinker branch yet. And also you must execute the above branch from master branch. So to go to tinker, you need to checkout -

git checkout tinker

Then, you would do some creative modifications. You can view the files you changed by -

git status

Now you need to add the modified files so that the file is marked as something called staged. Refer to this for more info. You can simply do -

git add .

This adds all the un-staged files. Refer to the link I gave to add certain files only. Now you must commit your changes. You do that by -

git commit -m "Changed page title"

What you give after -m is the commit message. It is highly recommended to give meaningful commit messages, i.e., commit messages must shortly describe what you have done. They shouldn't be something like Added code, Modified page, etc.

Now push your changes. Personally I like the Atlassian tutorials a lot. I hope you'll find them useful too :smile:

[shubham49]

I made new branch tinker and committed changes. On pushing changes I got "every thing up to date"

Now just want to verify if everything is set up correctly!

[VamsiSangam]

LGTM :+1: Nice work! Please get started by solving a d.FirstTimers issue. You are allowed to solve only a single d.FirstTimers issue, after which you must move to d.Contributors issues, where you can work on multiple d.Contributors issues.

Good luck :smile:

[shubham49]

Do you know why these kind of test cases are getting failed?

It seems like some sort of character encoding issue.
I have also changed Text file encoding to UTF-8.

[VamsiSangam]

Those kind of errors occur due to incorrect encoding scheme. Please check if you have configured your eclipse's project settings according to steps given in ide-usage.md. What you need to check for this error is Text encoding in the 4th point

1. Configure the following project-specific settings (all can be found in Project → Properties → ...):

Change the encoding scheme to UTF-8.

[shubham49]

yes I had changed it.

[VamsiSangam]

Well if that doesn't work, there are a few other options to do it in eclipse. Try these and let me know if it solves the issue.

[shubham49]

This one worked. I think this link should also be added to docs(may be in troubleshooting-guide.md)

[VamsiSangam]

There were plenty of options in that link, right? Can you specify which one worked?

@whipermr5 similar encoding related issues have occurred to people before, and the link helped. May be we should consider adding the link to docs in the future if this issue keeps troubling the devs.

[whipermr5]

@VamsiSangam Good idea. Can you open an issue for it?

[VamsiSangam]

Done. #7274 😄

[shubham49]

@VamsiSangam option 1 worked for me.

[VamsiSangam]

Noted @shubham49 👍 Thanks! 😄