Teammates: Use 'Evaluee/recipient' in student submission UI

[damithc]

At some point we changed the feedback submission form to use the term _Evaluee_ instead of _Recipient_. However, some parts of the UI still uses the old term, this sentence for example:

Instructors in this course can see your response, the name of the recipient, and your name.

We need to use the new term everywhere.

[LiHaoTan]

Additional context: The change from _Recipient_ to _Evaluee_ was decided in #7812.

[KshitijKythe]

Can I work on this? @damithc

[sukanta-27]

Can I take this? @damithc @LiHaoTan

[LiHaoTan]

@KshitijKythe @sukanta-27 we don't require that you ask when taking up an issue. However, it's common courtesy to not work on something else someone is working on.

Given that @KshitijKythe have decided to work on this issue first, @sukanta-27, it might be better for you to take up another issue. If you do feel strongly that you want to work on this issue, you could discuss it with @KshitijKythe

[sukanta-27]

@LiHaoTan Okay.
@KshitijKythe Have you already started working on it?

[KshitijKythe]

@sukanta-27 yes I have. If I can't finish it off soon, I'll be sure to hand it off to you. :)

[sukanta-27]

@KshitijKythe Okay :)

[sukanta-27]

@KshitijKythe Any updates?
It's been 20 days and you haven't submitted a PR yet, so, just wondering if you are still working on this or not.

[KshitijKythe]

@sukanta-27 Hey, my apologies, I've been busy with some other stuff, you go ahead and raise a PR. Just a pointer, some static pages like instructorHelp.jsp and features.jsp have many hits for 'recipient'. So just confirm with the core members where all it needs to change. Sorry for the delay.

[sukanta-27]

@KshitijKythe Thank you for the tip. I really appreciate that. :smile: I will start working on it.

[sukanta-27]

@damithc @LiHaoTan Sir, to be clear, There are many variables with the word 'recipient' in it. like recipientType ,FEEDBACK_QUESTION_CONSTSUMTORECIPIENTS, do they need to change to Evaluee as well, (like evalueeType and FEEDBACK_QUESTION_CONSTSUMTOEVALUEES) or just the parts which are shown in the UI.

[damithc]

There are many variables with the word 'recipient' in it. like recipientType ,FEEDBACK_QUESTION_CONSTSUMTORECIPIENTS, do they need to change to Evaluee as well, (like evalueeType and FEEDBACK_QUESTION_CONSTSUMTOEVALUEES) or just the parts which are shown in the UI.

@sukanta-27 Let's do the user-visible ones first. Changing it internally can be separate issue.

[sukanta-27]

@damithc Okay, I am already on it.

[wkurniawan07]

@damithc it may be just me, but giver-evaluee does not sound like a good pair. It's either giver-recipient or evaluator-evaluee. In fact I find the term evaluee rather weird because it is really not commonly used in everyday English.
In #7812, "evaluee" is introduced to replace "To", NOT to replace "recipient". Which brings me to this question: why change "To" to "evaluee" instead of "recipient"? Had it been "recipient" back then instead of "evaluee", this issue is not even necessary.

[damithc]

giver-evaluee does not sound like a good pair.

@wkurniawan07 that's true.

The root cause is that TEAMMATES try to cater for two basic functions: doing _evaluations_ (evaluator-evaluee) and giving _feedback_ (giver-receiver)

The reason we changed receiver --> evaluaee is because a user commented that respondents get confused when they see recipient for questions that the person being evaluated is not supposed to _receive_ anything.

Options:

1. use evaluator-evaluee as this seems to fit both feedback and evaluations
2. use giver/evaluator-receiver/evaluee but this will take extra space
3. pick the correct term based on question type. This option is too complex.
4. keep current giver-evaluee
   
   
   
   1. Use evaluee everywhere
   
   
   2. Use evaluee only in student views
   
   
   3. Use evaluee/recipient only in student views
   
   
5. go back to giver-receiver
6. use respondent-evaluee
7. ...?

What do you think? 4.ii or 4.iii seem the easier and closest to current situation.

[sukanta-27]

@damithc @wkurniawan07 Sir, as I am working on this, and has already replaced recipient to evaluee in Features.jsp (there was 1 hit) and InstructorHelp page (there were 60 hits), I am just curious to know, why only replace the words in "Student views" (if they are to be replaced at all), I mean why not replace it in instructor views as well?

and FWIW If I had to choose I think option 1 is good. evaluator-evaluee is a good pair. :smile:

[damithc]

I am just curious to know, why only replace the words in "Student views" (if they are to be replaced at all), I mean why not replace it in instructor views as well?

We used giver/receiver exclusively before, both in UI and backend. Changing it to something else everywhere is non-trivial. It's not simply a matter of search-and-replace.
The confusion with the term 'recipient' is related to students only, even more specifically, in the submission form. If we use option 4.iii (i.e. simply add /evaluee), it solves the problem with minimal change.

[sukanta-27]

@damithc Okay, I will work with option 4.iii
Should I revert the changes that I made in InstructorHelp page and Features page and start fresh?

[damithc]

This is the current status (and the discrepancy):

One way to fix this as follows, which also improves the UI (by removing the repetition Evaluee):

@TEAMMATES/seniordevs what do you think?

[sukanta-27]

@damithc
Update:
I have changed the UI as suggested. [Screenshot]

But apparently moving the Evaluee/Recipient from response.tag to questionWithResponses.tag also created this problem. [Screenshot] below.

Trying to fix this. :sweat_smile:

[damithc]

I have changed the UI as suggested.

@sukanta-27 UI looks good. 👍