Signal-desktop: Signal Desktop fails to detect portrait-oriented image attachments

[pde]

JPG images use JFIF headers to work out which orientation (portrait, landscape, reverses of those) the image should have. But Signal Desktop (and maybe other versions; I'm not sure?) don't get this right.

Here's an example of an image that renders right in just about every piece of most software except Signal :)

[liliakai]

This is a longstanding issue in chromium. It was fixed for direct-viewing of images but not for embdedded img tags. Four years later and we're still waiting on support for css image-orientation.

In the meantime, recent versions of the library we use for auto-scaling images now include support for reading and rendering exif orientation.

[Dyras]

Happened just now
https://gist.github.com/a37e96cb4a2d7e272133da41ce9a5df4
Here's the picture
https://vgy.me/WZmtBK.jpeg

The picture was taken by a camera last summer, if that matters. Check the exif!

[Dyras]

Happened again, and GIMP tells me the picture's EXIF data is rotated.
https://vgy.me/xdEBP6.png

[liliakai]

We don't need any more reports or examples here, thanks.

[fsoullier]

Issue still present on Desktop version 1.0.34

[fsoullier]

Issue still present on Desktop version 1.0.36
This bug has been open since last December, I am not a developer but can't we leverage something like https://github.com/blueimp/JavaScript-Load-Image to quickly resolve this?

[supertobi]

I had the same problem today with the v1.0.36 (win).

WARNING: I'm not a js developer and I don't know the Signal code.

But if I see it right, someone with more knowledge just needs to insert this code:
https://nsulistiyawan.github.io/2016/07/11/Fix-image-orientation-with-Javascript.html

Here:
https://github.com/WhisperSystems/Signal-Desktop/blob/d1f7f5ee8c1111c2b12a2870c64a830ca0f4fd04/js/views/file_input_view.js#L94

[supertobi]

Not fixed in v1.0.38

[fsoullier]

Supertobi, I am not a developer neither but just did what you suggested and created a pull request. Let's cross fingers and see what happens!
https://github.com/WhisperSystems/Signal-Desktop/compare/development...fsoullier:patch-1

[scottnonnenberg]

@fsoullier It looks like that's not a pull request yet. A couple more steps! I look forward to trying out your changes!

[fsoullier]

@scottnonnenberg Thanks for pointing it out. I am completely new to this. That shoud be a pull request now. I'd be extremely curious to see if my copy/pasting fu leads to a bug correction. Looking forward to hearing your feedback!

[Fancellu2]

Even before this is fixed, it would be a good idea to have rotate buttons on the zoomed image.

[supertobi]

Not fixed in v1.0.39

[scottnonnenberg]

@supertobi Please don't post those kinds of messages. The release notes for v1.0.39 don't claim that the bug is fixed in that version.

[foss-]

@fsoullier can you link to the PR? I briefly looked but couldn't find it in the pending PRs. Or do you need assistance with creating the PR?

[fsoullier]

Here is the PR again...I guess
https://github.com/signalapp/Signal-Desktop/compare/development...fsoullier:patch-1

I am a total noob and merely copy pasted a proposed fix. I'm baffled that such a basic fix has not yet been implemented.

[gasi]

We’ve fixed this bug for newly received image attachments and it will be available in the next beta. We look forward to hearing about your feedback.

[Dyras]

@gasi I would kiss you if I could!

(No homo)