Scratch-gui: Click 'full screen mode' button will raise Failed prop type warning

Created on 31 Jan 2019  路  5Comments  路  Source: LLK/scratch-gui

Expected Behavior

no warning in console

Actual Behavior

Warning: Failed prop type: The prop showBranding is marked as required in StageHeaderComponent, but its value is undefined

screen shot 2019-01-31 at 5 28 26 pm

Steps to Reproduce

  1. npm start
  2. in browser open http://0.0.0.0:8601/
  3. click 'full screen mode' button above the canvas
    screen shot 2019-01-31 at 5 28 39 pm

  4. warning will be displayed in browser console

Operating System and Browser

Mac OS Safari/Chrome/Firefox

bug has patch help wanted

All 5 comments

This is the same as https://github.com/LLK/scratch-gui/issues/4445, so closing as a duplicate

Woops sorry no it is not a duplicate, my bad!

^Thank you for making that connection @thisandagain! Not sure why I didn't see that yesterday when making the PR.

@LukeSchlangen Of course! No worries at all.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

apple502j picture apple502j  路  4Comments

chrisgarrity picture chrisgarrity  路  4Comments

davidaylaian picture davidaylaian  路  4Comments

fsih picture fsih  路  3Comments

rschamp picture rschamp  路  3Comments