Scratch-gui: Remove ability to select tab button text

Created on 9 Dec 2017  路  4Comments  路  Source: LLK/scratch-gui

Currently, if you click twice on a tab button, the text is able to be selected, as shown:

screenshot

Consider removing this so that the text cannot be selected.

Possible Pros: the text selection can easily be trigged by accident and it doesn't look good
Possible Cons: users cannot copy the text

I already have a commit that implements the proposed change. I'm opening this issue for discussion.

enhancement has-patch help wanted
Source
picture davidaylaian

Most helpful comment

@kenny2github Sorry. I'm traveling (on my phone). I'll catch up with labels and PRs when I get back to my laptop.

picture thisandagain on 9 Dec 2017
👍2

All 4 comments

Good catch. Thanks. PR is welcome. :-)

thisandagain picture thisandagain on 9 Dec 2017
👍1

@thisandagain might want to label this with something? ;)

Kenny2github picture Kenny2github on 9 Dec 2017

@kenny2github Sorry. I'm traveling (on my phone). I'll catch up with labels and PRs when I get back to my laptop.

thisandagain picture thisandagain on 9 Dec 2017
👍2

@thisandagain ahhh, I see. No problem then :D

Kenny2github picture Kenny2github on 9 Dec 2017
Was this page helpful?
0 / 5 - 0 ratings

Related issues

kyleplo picture kyleplo  路  3Comments
TaiAurori picture TaiAurori  路  3Comments
rschamp picture rschamp  路  4Comments
kyleplo picture kyleplo  路  4Comments
thisandagain picture thisandagain  路  3Comments