Scratch-gui: Opening the backdrop library causes the stage backdrop editor to become selected

[rschamp]

Expected Behavior

_Please describe what should happen_
The backdrop editor should be selected when I choose a backdrop. If I don't do anything in the library, my place in the editor shouldn't change.

Actual Behavior

_Describe what actually happens_
Clicking the "Choose a backdrop" button and then hitting Esc, leaves the editor in the Stage's paint editor tab.

Steps to Reproduce

_Explain what someone needs to do in order to see what's described in Actual behavior above_
In a new project, with a sprite's code tab open, click the "Choose a backdrop" button, then hit Esc (or otherwise close the library without doing anything).

Operating System and Browser

_e.g. Mac OS 10.11.6 Safari 10.0_
Not browser related

[sjhuang26]

I will work on this.

[sjhuang26]

I noticed that the BackdropLibrary component is nested inside the CostumeTab component. Thus, when the CostumeTab is closed, the BackdropLibrary component can't be open. I don't think this makes sense, as the library is not "inside" the costume tab.

Maybe we should move the BackdropLibrary component into the root GUI component.

https://github.com/LLK/scratch-gui/blob/b4d4e25bf8773b02090283fea9d2dd76911e0201/src/containers/costume-tab.jsx#L293-L298

[rschamp]

@sjhuang26 Yes moving that into the root component makes sense, since the state is controlled by Redux anyway, it doesn't need a parent relationship like this.

[paulkaplan]

~Foxed!~ 🦊fixed