Scratch-gui: Dragging a large sprite out of the stage causes cropping

Created on 18 Apr 2018  路  3Comments  路  Source: LLK/scratch-gui

Expected Behavior

When you drag a sprite out of the stage, the entire sprite should be visible.
screen shot 2018-04-17 at 7 19 17 pm
(This is how larger sprites should behave)

Actual Behavior

When you drag a sprite that is too big to appear fully in the stage, the sprite is cropped from the bottom up when it is dragged out of the stage.
screen shot 2018-04-17 at 7 19 43 pm
(Notice how feet are cropped)

Steps to Reproduce

  1. Set a sprite's size to a large number so it no longer fits in the stage. (400 works for the Scratch Cat sprite)
  2. Drag sprite out of stage.

Operating System and Browser

Mac OS 10.13.4 | 64-bit Google Chrome 65.0.3325.181


Moved from LLK/scratch-gui#1806
/cc @bartljak


Moved from LLK/scratch-blocks#1454
/cc @thisandagain @bartljak

bug

Most helpful comment

Hi @thisandagain, I came across this bug in my experimental-AR-extension work (because I use the extraction mechanism to get a sprite's image data), and I traced the issue (I think) down to something in scratch-render in https://github.com/LLK/scratch-render/blob/develop/src/RenderWebGL.js#L1032. If it's not too crazy to get started developing for Scratch Renderer (before release), I could take a stab at trying a small fix.

All 3 comments

Sorry for all the confusion / movement on this. Codetree had a major hiccup. 馃槥

Hi @thisandagain, I came across this bug in my experimental-AR-extension work (because I use the extraction mechanism to get a sprite's image data), and I traced the issue (I think) down to something in scratch-render in https://github.com/LLK/scratch-render/blob/develop/src/RenderWebGL.js#L1032. If it's not too crazy to get started developing for Scratch Renderer (before release), I could take a stab at trying a small fix.

@evhan55 Go for it!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rschamp picture rschamp  路  3Comments

apple502j picture apple502j  路  4Comments

kyleplo picture kyleplo  路  3Comments

ntlrsk picture ntlrsk  路  3Comments

fsih picture fsih  路  3Comments