Image-sequencer: Make Fisheye-gl module compatible with nodejs

[jywarren]

This module uses webgl, which isn't available in Node, so let's try to use one of these libraries to make this possible:

https://github.com/publiclab/image-sequencer/tree/main/src/modules/FisheyeGl

This lib is a pure-JavaScript implementation of OpenGL, so it could work on servers without a GPU: https://github.com/Overv/JSGL

This one, i believe, would just make the GPU accessible to Node, so is less useful but still OK: https://github.com/stackgl/headless-gl

This could then open up the possibility of making a perspective-distort module based on:

https://github.com/jywarren/webgl-distort

[gitmate[bot]]

GitMate.io thinks the contributor most likely able to help you is @ccpandhare.

Possibly related issues are https://github.com/publiclab/image-sequencer/issues/27 (add fisheyegl module), https://github.com/publiclab/image-sequencer/issues/200 ("Meta" modules -- modules made of other sequences of modules), https://github.com/publiclab/image-sequencer/issues/108 (Math Module), https://github.com/publiclab/image-sequencer/issues/112 (Scale module), and https://github.com/publiclab/image-sequencer/issues/434 (Rotate module).

[Divy123]

Is this issue still open? I would like to work upon it.

[jywarren]

Oh this would be really cool!

On Sun, Dec 16, 2018, 12:53 PM Slytherin <[email protected] wrote:

Is this issue still open? I would like to work upon it.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/542#issuecomment-447662615,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ2pmTjo9sT_xF7_gu8_F4sQaolAUks5u5oiMgaJpZM4ZSaIf
.

[Divy123]

@jywarren I was going through with the first link as provided above by you but I found that there was no method for taking an image as an input and always requires an html 'div' to work with.
So, can you please guide me on this?
Should I go on with the second one?
cc: @tech4GT

[jywarren]

Ah, you mean JSGL? Hmm. Would it be possible to run it in phantomjs even in NodeJS - using a div still but not needing a browser? Maybe there's some questions/docs about that in the repo issues?

[Divy123]

As of now I saw phantomjs development is suspended. So, cool, I will find a way to figure it out.
Thanks @jywarren .

[jywarren]

Oh really? Is it because of chrome headless?

On Wed, Dec 26, 2018, 6:08 AM Slytherin <[email protected] wrote:

As of now I saw phantomjs development is suspended. So, cool, I will find
a way to figure it out.
Thanks @jywarren https://github.com/jywarren .

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/542#issuecomment-449950840,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ0QWGKUlslVRKxbyLIBRJPHWdpakks5u81h7gaJpZM4ZSaIf
.

[tech4GT]

Ohh I really like the idea of running it in a headless browser, this can enable running any browser specific feature in node as we go! Very neat!! :)

[Divy123]

@jywarren Its because they are receiving less contributions these days. So I guess we should not rely on it. Also I explored JSDOM for this but it requires Node v8 or newer.

[jywarren]

Ah, i see many projects have switched to Chrome Headless:
https://github.com/gruntjs/grunt-contrib-jasmine/pull/269/

On Wed, Dec 26, 2018 at 9:39 AM Slytherin [e-mail] wrote:

@jywarren https://github.com/jywarren Its because they are receiving
less contributions these days. So I guess we should not rely on it. Also I
explored JSDOM for this but it requires Node v8 or newer.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/542#issuecomment-449975356,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ0T78Yj-xrKMEdHXbUvq09Bn47Tjks5u84oegaJpZM4ZSaIf
.

[Divy123]

@jywarren @tech4GT Sorry this issue is taking too much time but I would like to mention that almost all the libraries or modules I saw for this are using node v6+ .
So if we can change out travis can be configured to work with node v6+.
Would like to know your opinion please.

[jywarren]

Hm, sure, want to open a travis.yml change PR?

On Wed, Jan 16, 2019 at 12:53 PM Slytherin [e-mail] wrote:

@jywarren https://github.com/jywarren @tech4GT
https://github.com/tech4GT Sorry this issue is taking too much time but
I would like to mention that almost all the libraries or modules I saw for
this are using node v6+ .
So if we can change out travis can be configured to work with node v6+.
Would like to know your opinion please.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/542#issuecomment-454875347,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJyOltZbXQwxRBSALp9Zmjob68uraks5vD2bkgaJpZM4ZSaIf
.

[Divy123]

Ya sure.

[aashna27]

@Divy123 please give me sometime I ll search on this and then will let you know.

[Divy123]

Thanks @aashna27 .
@jywarren I have made some temporary changes to the fisheyegl.js file in src folder in fisheyegl module for fisheye correction.
Please have a look
https://dpaste.de/H3Kf
What I am stuck at is I am using gl and I think it does not support gl.texImage2D function.
Any suggestions please?

[Divy123]

Also I have tries using node-canvas apart from jsdom but that too does not support webGl.
Can you please help me @jywarren ?

[harshkhandeparkar]

Can be discussed in #216

[harshkhandeparkar]

216 is pinned and discusses the same thing