Eddiebot: Bug: Failed to assign opensource role

[BOLT04]

The opensource role is self-assignable, but still @ritvij14 got an error. Maybe we should test what happens when the user already has that role. The response should not be an error in this case, but like a warning saying "You already have that role".

[eddiejaoude]

oh good spot 👍

[github-actions[bot]]

Stale issue message

[eddiejaoude]

This has not come up again, but we probably need to clarify this stalebot before it is closed

[Vyvy-vi]

This has been potentially fixed in #347

[eddiejaoude]

This has been potentially fixed in #347

Can it be tested to make sure? I can test it when I get to the PR - I am still working my way through notifications.

[Vyvy-vi]

The opensource role is self-assignable, but still @ritvij14 got an error. Maybe we should test what happens when the user already has that role. The response should not be an error in this case, but like a warning saying "You already have that role"

347 implemented the above.

Though, I wasn't able to reproduce this issue. (the initial bot, before #347, just reassigned the role. I think perhaps this was a config issue in the deployed bot at that time?)

[BOLT04]

I didn't reproduce it either, but I tested what happens if you assign a role you already have:

@Vyvy-vi and @eddiejaoude, what do you think about closing this issue? The error in the issue description was probably the default, and now the text changed.

[Vyvy-vi]

yes, I think this can be closed, since #347 adds slightly more detailed messages. Maybe, we could look at this, if the problem arises again

[eddiejaoude]

I am happy for it to be closed. I will let @BOLT04 close it as you are the author of the issue 🤓