Botframework-composer: Visual Design | selection feedback for 'For - Each'

Created on 6 Sep 2019  路  4Comments  路  Source: microsoft/BotFramework-Composer

when selecting some or all of the elements of a 'For - Each' loop, a bounding box appears tightly around the elements.
Screen Shot 2019-09-05 at 4 06 10 PM

Expected: Each of the elements that are part of the selection get their OWN selection feedback, ie the node and the 'loop indicator' icons get a selection feedback outline.

@DesignPolice - do we already have a picture of this? If not, @yeze322 do you need one or is it pretty straightforward?

4.6 Visual editor Bug

Most helpful comment

Actually, based on the new selection rule, this should have the same behavior as a Branch node.

I've just quickly put together the proper selection UI for a ForEach node
https://www.figma.com/file/04DymSq4xElhOBdAyutvvTbq/Composer-SH-06.19?node-id=1741%3A3901

As a result, the tap targets of a ForEach node would be the node itself, instead of the entire area the loop is covering.

All 4 comments

I didn't set this interaction up, @sangwoohaan did, but I can get the file and make a jpg and link for Yeze

Actually, based on the new selection rule, this should have the same behavior as a Branch node.

I've just quickly put together the proper selection UI for a ForEach node
https://www.figma.com/file/04DymSq4xElhOBdAyutvvTbq/Composer-SH-06.19?node-id=1741%3A3901

As a result, the tap targets of a ForEach node would be the node itself, instead of the entire area the loop is covering.

Yup that's it (-:

Thanks for all your feedbacks, all dependencies are ready now, I'm going to work on it :)

Was this page helpful?
0 / 5 - 0 ratings