Zulip-desktop: Write requestOptions function to replace request

[abhigyank]

Currently we proxy, certificate and ecdhCurve options in a request. This is leading to lot of redundancy in the code and could break parts where any option is missed. As mentioned in https://github.com/zulip/zulip-electron/pull/598#issuecomment-443425383 it is better to write a requestOptions function that takes the domain as input and return the appropriate object according to domain and settings to be used request function,

[abhigyank]

@zulipbot add "Type: Enhancement" "help wanted"

[kanishk98]

@akashnimare @abhigyank as far as I understand, you want all places where request() is used for getting the response object to be replaced by requestOptions(), correct?
I believe @superbiche has already worked on a method in https://github.com/zulip/zulip-electron/pull/598/commits/b2fe8ce5040beb88f7885fad4756482d6c450e2f. Do you have any changes in mind for this?

[akashnimare]

@kanishk98 yeah, that's what we need to do here.

[superbiche]

@akashnimare @kanishk98 should be able to refactor the PR to include this (and other remarks from the issue it fixes) next week, I won't be working for my clients for a few days :)

[abhigyank]

@superbiche You could probably create a separate PR for this. Would be easier to keep track of and merge.

[kanishk98]

@abhigyank I saw that the referenced PR https://github.com/zulip/zulip-electron/pull/598 has not been merged yet. I'm unsure of how to proceed with this issue, should I hold on till the PR gets merged to master?

[vsvipul]

@zulipbot claim

[zulipbot]

Welcome to Zulip, @vsvipul! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-electron/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Sign the Dropbox Contributor License Agreement, so that Zulip can use your code.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

[zulipbot]

Hello @vsvipul, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[vsvipul]

@zulipbot i have opened a pr awaiting review :+1: