Woocommerce-ios: Review push notification doesn't open product review details when tapped

[astralbodies]

Describe the bug
When I received a push notification for a new product review, tapping it did not bring up the details of the review. I had product reviews up as the last screen I was using in the app before backgrounding it. The product review didn't appear in the list either until I pulled to refresh.

To Reproduce
Steps to reproduce the behavior:

1. Go to the Reviews tab.
2. Background the app.
3. Leave a product review to receive a push notification.
4. Tap the push notification to open the app.

Screenshots
Didn't take a screenshot as the text really covers it all.

Expected behavior
Tapping the push notification should force the review to be loaded and the details show up.

Mobile Environment
Please include:

• Device: iPhone 6s
• iOS version: 13.1.1
• WooCommerce iOS version: 3.5.0.0

[astralbodies]

Also the product name wasn't listed - only "Unknown".

[jaclync]

I noticed this issue in WCiOS 3.8.0.0 sometimes, this seemed to happen while the app has navigated to an Order or Review from a push notification before

[jaclync]

Re the comment above: I tried reproducing the issue by leaving the app in the background when it received the new order push notif, then receiving a new review push notif. Wasn't able to repro it this time though, it's probably caused by other reasons

[shiki]

I shared a similar scenario about order notifications in https://github.com/woocommerce/woocommerce-ios/issues/1867#issuecomment-639660324. I can reproduce the same for reviews.

• It consistently opens the last screen only if the device was locked.
• If the device was not locked, then the app opens the review details correctly.

My device was also in low power mode.

[rachelmcr]

I saw this issue repeatedly while testing 5.4.0.0, exactly as described in the original issue (app was backgrounded but device wasn't locked, had to pull refresh the review list to see the new review, and product name wasn't listed).

I backgrounded the app once on an order detail screen and twice on the My store tab, and each time I got the same results.

[shiki]

We changed the way Product Review push notifications are handled in https://github.com/woocommerce/woocommerce-ios/pull/2669 so that the product will always be loaded. However, it looks like there was a regression in https://github.com/woocommerce/woocommerce-ios/pull/2879. If the product was not previously downloaded on the device, then the Review details page is never shown.

In summary: There's a regression.

---

New Order push notifications seem to be working though.

[shiki]

I also found another bug that happens when the app was previously terminated. The review details page will be shown but immediately removed from the view. 🙈

1. Load all the products of the site.
2. Terminate the app.
3. Send a Product Review push notification.
4. Tap on the push notification.
5. The Review Detail page will be shown. But then it will be dismissed right away and the user will be navigated to the Reviews page.

[shiki]

☝️ The above was caused by https://github.com/woocommerce/woocommerce-ios/pull/2796 (5.1).

[designsimply]

I tested the steps provided in the original report and I was able to open review details as expected after tapping on a review push notification.

Review Push Notification|Product Review detail opened after tapping push notification|New review not in list after pressing back arrow at top left|New review appeared after pull-to-refresh on the review list
---|---|---|---
|||

^{Tested with WCiOS 5.9.0.0 TestFlight beta, iPhone 11, iOS 14.4.}

I was unable to see the new review in the reviews list until I did a pull-to-refresh but _only_ if the app was backgrounded. If the app was closed before receiving the push notification then the review list showed the review as expected. If the app was open then I received a snackbar notice and no push notification. I filed a separate issue for this at https://github.com/woocommerce/woocommerce-ios/issues/3584.

Recommend closing this issue if at least one other tester can no longer replicate the bug from the original report.

[hichamboushaba]

I confirm what @designsimply said, I can't reproduce the original issue, but can reproduce the new bug: the new review is missing from the review list if the app was backgrounded.