Walletwasabi: Wasabi Hard-fork

[benthecarman]

It seems with #2206 the wasabi "protocol" will be hard forked. With this we can fix and add some other stuff.

First thing that comes to my mind is fixing this:
https://github.com/zkSNACKs/WalletWasabi/blob/master/WalletWasabi/Backend/Models/Responses/VersionsResponse.cs#L9

[nopara73]

Can you? That's the hardfork protection itself.

[benthecarman]

Well if it is hardforking then why do we need to protect against it.

[nopara73]

No you cannot: https://github.com/zkSNACKs/WalletWasabi/blob/master/WalletWasabi.Backend/Controllers/SoftwareController.cs

It must work forever.

[nopara73]

This is the way of telling old clients the new version.

[yahiheb]

Was about to open a similar issue to discuss things that can be done if a hard-fork is needed.

[benthecarman]

This is the way of telling old clients the new version.

Oh, yeah that makes sense. Unfortunate that the one thing that can't change is where the typo is.

[benthecarman]

Was about to open a similar issue to discuss things that can be done if a hard-fork is needed.

https://github.com/zkSNACKs/WalletWasabi/projects/4

[yahiheb]

Was about to open a similar issue to discuss things that can be done if a hard-fork is needed.

https://github.com/zkSNACKs/WalletWasabi/projects/4

Can we add Ideas there?

[nopara73]

@yahiheb Sure.

[yahiheb]

I can't add Ideas there.
I have two things I wanna add (backwards compatibility related):

• We shouldn't prevent the user from typing a password with a space at the beginning or at the end. Why do we prevent the user from doing so?

• We should add an option to display the seed phrase.

[benthecarman]

We shouldn't prevent the user from typing a password with a space at the beginning or at the end. Why do we prevent the user from doing so? We should add an option to display the seed phrase.

The hard fork is for the client <-> server communication, we still need backwards compatibility for local files.