Vscode-pull-request-github: Cannot create a PR from codespaces

[sandy081]

• Create a codespace for https://github.com/microsoft/vscode-java-pack. It forked the repo as I do not have permissions.
• Try to create a PR from the forked repo using following options
  
  
  
  • Using parent repo
  
  
  • On master branch
  
  
  • Use last commit
  
  

🐛 I got following error

[RMacfarlane]

@sandy081 It sounds like you're using the stable version of the extension and not insider's, right?

[bamurtaugh]

I believe this stems from/relates to https://github.com/github/codespaces/issues/760? We're tracking that issue with the ghcs-scenario-blocking label (not that we need to change the label here, just that we're keeping an eye on that issue as a blocking one).

[RMacfarlane]

In the new create flow, this issue manifests as https://github.com/microsoft/vscode-pull-request-github/issues/2374. I have a fix out for that which ensures the dropdown gets populated, but it only lists the remotes that you have locally. Since we have metadata about whether or not a repo is from a fork, we could have a button or warning to create an upstream remote in this case.

Anyway, since the old create flow is already removed, I'm going to go ahead and close this issue

[sandy081]

@RMacfarlane It seems with new flow I can no longer create a PR against main repo from forked repo:

which I can do it in old flow

Not sure if this is being tracked by other issue, I would reopen this for this.

[RMacfarlane]

@sandy081 The dropdown lists only remotes you have locally. If you want to target the parent repo, add an upstream remote to it.

We want to encourage users to add an upstream so that other features will work as well. There is an existing codespaces issue to add an upstream automatically when a repo is forked, which is not yet completed