Vscode-pull-request-github: Cannot load avatars from GitHub Enterprise URLs

[lumaxis]

• Extension version: 0.1.2
• VSCode Version: 1.28.0-insider
• OS: macOS 10.13.6

Steps to Reproduce:

1. Open a Pull Request from a GitHub Enterprise repo
2. Add a PR comment

Screenshot:

This is likely because the user.avatar_url is used without authentication.

[shana]

Ah, enterprise avatars. There's some scenarios where retrieving avatars from enterprise will always fail regardless of authentication, and others where it will potentially spam the enterprise instance repeatedly if there are a lot of avatars to load - enterprise has a very short cache time for avatars (so they'll update quickly when you change them), which is a problem for clients loading them without caching.

GitHub Desktop has some workarounds for this in https://github.com/desktop/desktop/blob/master/app/src/lib/gravatar.ts and related calls.

[lumaxis]

Personally, I would even prefer not showing an avatar at all if it's not possible to load the actual one. This placeholder is not very pretty.

[StanleyGoldman]

Just to document what isn't working