Vscode-pull-request-github: Authentication endpoint is not obviously connected to GH

[kieferrm]

Issue Type: Bug

See the following screenshot. Neither the url of the auth endpoint nor the organization are obviously connected to GH. It would be better if the auth endpoint would be within github.com.

Extension version: 0.1.1
VS Code version: Code - Insiders 1.28.0-insider (96854113091424c07b28ba84b82b75a88b8455cb, 2018-09-10T05:12:30.432Z)
OS version: Darwin x64 16.7.0

[shana]

The GitHub for VSCode oauth app has been moved to the GitHub org, so the owner will now show up as github and it will show Owned and operated by GitHub at the bottom. I can't fix the redirect url right now (working on that), but hopefully this will help.

[auchenberg]

Re-opening to keep track of the move to a Github-owned domain.

[shana]

4cf3870b656e91908c4fee8766ff6402f77664c7 switches the authentication server domain to the new github.com domain. This is the client side change needed for this fix.

The server side fix (the url being shown in the permissions page, as seen on the screenshot) will be done today, so once the client side fix is live and everyone is updated, both sides will match.

Until then, some authentication transactions might show the herokuapp.com url at some point, but hopefully things will propagate to everyone quickly enough to not be confusing to too many users.

[shana]