Vscode-pull-request-github: Plan for November 2018

Created on 10 Nov 2018 · 4Comments · Source: microsoft/vscode-pull-request-github

Plan Items

[x] create PR @rebornix @queerviolet
[x] Support for suggest comments @rmacfarlane
[x] Investigate frequent re-login requests (expires too fast, no refresh?) #680 @rebornix
[ ] :runner: Windows performance issue #612 @rebornix
[x] Add client-side logging of GH requests to look for call optimizations @rebornix
[ ] :runner: grouping comments into a review
[x] edit PR title @rmacfarlane
[x] Publish daily insider version of the extension through CI @rebornix @rmacfarlane

Pain points / Missing functionality

[ ] intellisense for @mentions and issue numbers @rebornix
- [ ] incremental API V4 adoption
[ ] resolve a conversation @rebornix
[ ] flow for resolving conflicts @rebornix
[ ] delete branch after merging PR https://github.com/Microsoft/vscode-pull-request-github/issues/350 @rebornix
[ ] :hand: can't add images @rmacfarlane
[ ] can't choose options how to merge @rmacfarlane
[ ] allow me to keep track of which files I reviewed @RMacfarlane

iteration-plan

Source

kieferrm

❤4 👍4

All 4 comments

This is super exciting!

suggested changes/suggest comments

This is a feature similar to what we've been internally using through Nuclide Phabricator integration and we allow users to accept as many suggested changes as they would like and create one commit out of them, looks like it was one of the biggest asks by the community from the Github team during their public beta. Is there a proposed vscode core API that would enable extensions to power suggested changes in the editor? As a reviewer would I be able to edit code and use the diff as suggested changes to be pushed to the code author?

resolve a conversation

On Github resolving a comment is a sub action of hiding a comment, is this going to hook into that behavior?

In Nuclide we have a notion of resolving comments and it hooks up to Phabricator and is a way for a reviewer to see their comment has been addressed and as the code author for one to keep track of what comments have been addressed and what is pending. It also allows for a filter that can be used to show/hide resolved comments. With that use case would the concept of resolving a comment be specific to the pull request package or is this going to be leveraging vscode core API that allows marking a comment as resolved?

aadisriram on 12 Nov 2018

❤1

On Github resolving a comment is a sub action of hiding a comment, is this going to hook into that behavior?

Yes, this can be done from the extension side. We can send a comment update to the core and ask the core to either remove the comment or set the collapsible state of the comment to false.

it hooks up to Phabricator and is a way for a reviewer to see their comment has been addressed and as the code author for one to keep track of what comments have been addressed and what is pending

We'll probably introduce Flag/Type property for comments or comment threads in the core API. With the flag, we can

Sort/Filter comments in Comment Panel.
Display the state in both Comment Panel and Comment Widget.
We can change the type of a comment/comment thread in Comment directly. Once the type of the comment is changed, we can update the visibility/collapsible state as well.

IMO it would be better than having the Resolve Conversation in the core API.