Trenchbroom: Issues manager no longer fixing issues

[sputnik2000]

Selecting an issue, right-clicking and choosing a fix no longer fixes the issue. This was working fine in the previous beta.

The issues I have tried to fix are:
Brush has non-integer vertices
Brush has non-integer plane points

Choosing Fix --> Convert vertices to integer or Fix --> Convert plane points to integer has no effect. The issues do not disappear from the Issues List and the filename does not have an * after it to indicate that changes have not been saved.

I'm using TrenchBroom-Win32-2.0.0-Beta-31439f2-RelWithDebInfo on a Windows 10 PC.

[kduske]

Hmm, I can't reproduce this. Can you upload the map so that I can check what's going on?

[sputnik2000]

Here's the map. Still a long way from being finished. Built entirely in TB1. I just opened it in TB2 to see if I could fix some of the issues. Thanks.
wreckedtubeTB2.zip

[kduske]

I can apply quick fixes, and that appears to work for me. However a lot of the brushes result in errors and crashes, so I'm going to work on those first.

[eGax]

The big question I have is how are you even able to open the map in TB2? Using the Linux Alpha 63a040d or 31439f2 builds crashes TB2 on map open with this in the terminal:

]$ trenchbroom 
The program 'trenchbroom' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadValue (integer parameter out of range for operation)'.
  (Details: serial 17696 error_code 2 request_code 154 minor_code 3)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)
]$ 

[sputnik2000]

I've never had any trouble opening the map in TB1 or TB2. It also compiles and launches every time. I'm sure it's a real mess from a design point of view as it's my first attempt at map-building. But it does open on my Windows 10 PC.

[eGax]

@sputnik2000 thanks for the reply. It could be just my system then.

[kduske]

I can open it fine in TB2, but there are definitely problems with the issue browser and quick fixes which I'm working on right now. @eGax the BadValue error is unrelated I think.

[kduske]

@eGax see bug #1367. This should no longer happen. Does it also crash when you open any other map, or create a new one?

[eGax]

YES it was totally on my end only, sorry. No idea why, but I did have a pretty hefty system update earlier that included an Nvidia driver, kernel update and multiple libraries that probably required a reboot. My issue cleared up right after rebooting and the map loaded fine. Sorry to distract from your issue.

I've never used the fixes in the Issue browser before. It would be nice if you could select a group of issues then press fix once and have TB attempt to fix all of them one by one instead of just picking 1, selected fix, picking the next, selecting fix, and so on...

[kduske]

Alright, thanks for clearing that up. You can do that already, provided all issues are of the same type. For different types of issues that would not work since they have different fixes (and some have more than one possible fix).

[eGax]

I've been able to clean up a lot of the issues within TB2, but I see what you mean by the crashes. Some crash instantly and others just freeze the editor outright forcing me to wait a few minutes for it to crash with, "Reason: std::exception: std::bad_alloc" or I just kill the process/window. I have the crash text (wreckedtubeTB2.5-crash-4.txt) from attempting to fix non-integer vertices one of the offending brushes 2543. Same brush crashed the program 4x in a row when attempting to fix.

// brush 2543
{
( -14 -351 1018 ) ( -52 -300 1018 ) ( -1 -354 995 ) rock3_8 -1.28601 -6.46194 113.395 0.943603 1.06043
( -52 -300 1018 ) ( -14 -351 1018 ) ( -114 -304 1019 ) rock3_8 -28.9783 0.638519 81.5019 0.875609 -1
( -259 -377 691 ) ( -114 -304 1019 ) ( -284 -379 693 ) rock3_8 -20.4888 -8.56413 -87.0938 1.30373 1.02112
( -121 -351 779 ) ( -23 -308 967 ) ( -259 -377 691 ) rock3_8 -20.4888 -8.56413 -87.0938 1.30373 1.02112
( -202 -371 705 ) ( -121 -351 779 ) ( -259 -377 691 ) rock3_8 -20.4888 -8.56413 -87.0938 1.30373 1.02112
( -113 -304 1019 ) ( -259 -377 691 ) ( -52 -300 1018 ) rock3_8 -20.4888 -8.56413 -87.0938 1.30373 1.02112
( -23 -308 967 ) ( -52 -300 1018 ) ( -259 -377 691 ) rock3_8 -20.4888 -8.56413 -87.0938 1.30373 1.02112
( -23 -308 967 ) ( -1 -354 995 ) ( -52 -300 1018 ) rock3_8 -1.28601 -6.46194 113.395 0.943603 1.06043
( -104 -400 798 ) ( -1 -354 995 ) ( -121 -351 779 ) rock3_8 -1.28595 -6.46191 113.395 0.943603 1.06043
( -144 -372 733 ) ( -121 -351 779 ) ( -202 -371 705 ) rock3_8 -26.8653 -10.137 25.6205 1.15394 -1
( -202 -371 705 ) ( -239 -416 764 ) ( -104 -400 798 ) rock3_8 26.1202 -7.68527 81.5004 0.875611 -1
}

As I fix more fix non-integer vertices I save the map as I go. It had crashed again on a "bad" brush(don't have the # of the offending brush) or whatever. When I reopened the map TB2 I'm greeting with popup window, "Colinear face points: (-381 692 609) (-376 696 607) (1.02967e+154 8.62798e+153 -5.14834e+153)"

Search the map file in text editor I find only two brush with an "e+" in them.

// brush 1990
{
( -246 886 812 ) ( -360 879 908 ) ( -361 887 869 ) ground1_8 -3.22961 -11 0 1 1
( -253 906 579 ) ( -318 915 631 ) ( -317 918 611 ) ground1_8 -2.59778 -11 -180 0.96582 -1
( -317 865 869 ) ( -304 871 854 ) ( -307 843 868 ) ground1_8 20.5378 -11 0 0.935425 1
( -308 904 652 ) ( -319 936 613 ) ( -314 924 609 ) ground1_8 18.8987 -11 0 1.16003 1
( -289 852 910 ) ( -271 877 879 ) ( -275 867 879 ) ground1_8 20.5378 -11 0 0.935425 1
( -302 864 864 ) ( -300 752 800 ) ( -323 736 864 ) ground1_8 20.5378 -11 0 0.935425 1
( -381 692 609 ) ( -376 696 607 ) ( 1.0296677006788885e+154 8.6279824225537133e+153 -5.1483385033944427e+153 ) ground1_8 -29.8627 10.3311 -180 1.12122 -1.06477
( -361.43353271484375 887.0830078125 869 ) ( -410.44314575195312 626.9022216796875 869 ) ( -376.05593872070312 940.6944580078125 613 ) ground1_8 -6.20056 -11 0 0.985596 1
( -340 715 676 ) ( -393 771 684 ) ( -399 720 736 ) ground1_8 13.0233 -11 0 1.01074 1
( -395.11709594726562 730.46435546875 613 ) ( -376.05593872070312 940.6944580078125 613 ) ( -410.44314575195312 626.9022216796875 869 ) ground1_8 13.0233 -11 0 1.01074 1
( -332 736 864 ) ( -460 736 864 ) ( -332 736 992 ) ground1_8 -29.8629 10.3311 -180 1.12122 -1.06477
( -361.43353271484375 887.0830078125 869 ) ( -309.13494873046875 881.35186767578125 869 ) ( -410.44314575195312 626.9022216796875 869 ) ground1_8 4.68274 -1.28052 75 1 1
( -376.05593872070312 940.6944580078125 673.745361328125 ) ( -395.11709594726562 730.46435546875 673.745361328125 ) ( -314.23672485351562 924.13006591796875 673.745361328125 ) ground1_8 4.68298 -1.28076 75 1 1
}

AND

// brush 1993
{
( 490 1357 830 ) ( 505 1352 821 ) ( 467 1333 830 ) wgrass1_1 -27.5519 7.96594 -75 1 -1
( -8.2895972136578735e+153 1.6579194427315747e+154 7.5852523523666821e+153 ) ( 511 1238 765 ) ( 504 1244 769 ) wgrass1_1 -27.5519 7.96594 -75 1 -1
( 499.766357421875 1171.6246337890625 679 ) ( 490.76638793945312 1129.6246337890625 830 ) ( 557.66534423828125 1178.1771240234375 679 ) wall11_6 -25.9648 -15 -180 0.965912 1
( 559.66534423828125 1190.1771240234375 830 ) ( 557.66534423828125 1178.1771240234375 679 ) ( 490.76638793945312 1129.6246337890625 830 ) wall11_6 -25.9648 -15 -180 0.965912 1
( 557.66534423828125 1178.1771240234375 679 ) ( 559.66534423828125 1190.1771240234375 830 ) ( 542.618896484375 1328.16845703125 679 ) wall11_6 1.24719 25 180 0.965927 -1
( 454.71994018554688 1304.615966796875 679 ) ( 542.618896484375 1328.16845703125 679 ) ( 421.71994018554688 1187.615966796875 830 ) wall11_6 -1.36108 -15 -180 0.965912 1
( 499.766357421875 1171.6246337890625 679 ) ( 454.71994018554688 1304.615966796875 679 ) ( 421.71994018554688 1187.615966796875 830 ) wall11_6 -23.1178 25 180 0.965927 -1
( 490.76638793945312 1129.6246337890625 830 ) ( 499.766357421875 1171.6246337890625 679 ) ( 421.71994018554688 1187.615966796875 830 ) wall11_6 5.68274 25 180 0.965927 -1
( 392 1203 793 ) ( 392 1203 921 ) ( 423 1192 783 ) wall11_6 5.68274 25 180 0.965927 -1
( 477 1173 755 ) ( 477 1173 883 ) ( 477 1045 755 ) wall11_6 -23.1178 25 180 0.965927 -1
( 479.618896484375 1194.16845703125 830 ) ( 421.71994018554688 1187.615966796875 830 ) ( 542.618896484375 1328.16845703125 679 ) wall11_6 -1.36115 -15 -180 0.965912 1
( 559.66534423828125 1190.1771240234375 830 ) ( 479.618896484375 1194.16845703125 830 ) ( 542.618896484375 1328.16845703125 679 ) wall11_6 30.056 25 180 0.965927 -1
( 557.66534423828125 1178.1771240234375 679 ) ( 542.618896484375 1328.16845703125 679 ) ( 499.766357421875 1171.6246337890625 679 ) wall11_6 -27.5414 7.96594 -75 1 -1
}

Is any of this any help? If not I'll stop reporting here, but I still want to try to clean up the rest is possible since I've got most of them resolved. Its getting much harder the smaller the issue count gets because the map may seem fine while your fixing it, but if I save it, close TB2 and reopening the map it crashes the editor on load.

[eGax]

Something very weird to me during this. If I open my version of the map wreckedtubeTB2lotafixes.map.txt with fixes up to this point it opens fine in TB2. Not doing anything to the map other than saving in the editor as another name wreckedtubeWTF_thiswillcrashonnextopen.map.txt
and then loading that map into the editor crashes it! trenchbroom-crash-17.txt

Now If I make a copy of the working map file outside of the editor and it loads just fine.

[kduske]

That's a different issue. Please don't hijack issue reports with such things. I'll create a new issue.

[eGax]

DIDN'T know if it was related or not. I'm not trying to hijack anything, trying to help by reporting, but thanks for creating a new issue for it.

[kduske]

Alright, I have made some fixes to the vertex snapping command. Due to the way brushes are stored in the map file, it is not always possible to snap vertices to integer positions, therefore you may sometimes observe the effect that a fix doesn't take. I will add a message dialog informing the user of this problem.

[sputnik2000]

@kduske Thanks, that's great to hear.

@eGax And thanks for looking into my mess of a map, I'm sure it wasn't easy.

[kduske]

Alright, I have completely rewritten the vertex snapping code and it now successfully snaps most brushes in this map. Some can't be snapped, but this is a limitation of the map format, not of TrenchBroom per se. More importantly, the editor doesn't crash anymore when attempting to snap vertices.