The comment should show steps to assign the task of adding the sig mention to others if the issue owner (person opening the issue) is not able to add it.
@grodrigues3
/assign @crimsonfaith91
Sounds good to me. Note that non-org members can't mention sigs directly, but they will still be able to add a sig label based on this PR:
Great! I will start working on this issue. :)
Wait, I thought the bot should chat back. If you are not in the org and you type @ sig-network-pull-requests, the bot should recomment and the mention should work
I see. In this case, should we still change the comment? I sent out a PR changing the munger's comment to give users 3 options to add the sig label:
There are no sig labels on this issue. Please add a sig label by:
(a) mentioning a sig: @kubernetes/sig-<some-github-team>
(b) specifying the label manually: /sig <some-label>
(c) assigning another user to add the label: /assign @<some-user>
I think (a) and (b) suffice.
a) and b) work well enough. 2 suggestions
1) Clarify that a) will trigger a notification to the team
1) List one team per sig that they can mention.
Something like. You can type @kubernetes/sig-[TEAM_NAME]-misc where TEAM_NAME is replaced with one of the following:
node, network, api-machinery, etc.
There is no autocomplete for non org members so having the list of teams would probably be helpful.
Instead of listing the teams, perhaps we can add a link to: https://github.com/kubernetes/community/blob/master/sig-list.md
SGTM
Is this done? Can we close this?
it is done :)