Test-infra: Cherrypick lables name not consistant

Created on 26 Jul 2018  路  4Comments  路  Source: kubernetes/test-infra

We have a cherrypick-candidate and cherrypick-approved labels and then there is a cherry-pick-not-approved (i.e. do-not-merge/cherry-pick-not-approved). Notice cherrypick vs cherry-pick. Some inconsistency here and it also makes it hard to search issues/labels related to cherry-pick in a single search.
@spiffxp @cblecker @parispittman - I was looking at some labels in relation to discussion we had in ContribEx meeting today and noticed this. If it makes sense to rename these label(s) for consistency and for better usage, I will create a PR but wanted to run by your thoughts first. I also noticed some general inconsistency in doc at few places with use of "cherry pick" vs "cherry-pick vs "cherrypick" but I'm more concerned about labels.

areprow kinbug sicontributor-experience

Most helpful comment

TBH I'm inclined to not care if it involves adding more code to mungegithub. But I agree we should make them consistent in whatever solution we use to replace the existing cherrypick/cherry-pick/馃崚 process.

All 4 comments

@kubernetes/sig-contributor-experience-bugs
/area prow
/kind bug

TBH I'm inclined to not care if it involves adding more code to mungegithub. But I agree we should make them consistent in whatever solution we use to replace the existing cherrypick/cherry-pick/馃崚 process.

But I agree we should make them consistent in whatever solution we use to replace the existing cherrypick/cherry-pick/cherries process.

ref https://github.com/kubernetes/test-infra/pull/9128

Was this page helpful?
0 / 5 - 0 ratings

Related issues

BenTheElder picture BenTheElder  路  4Comments

lavalamp picture lavalamp  路  3Comments

sjenning picture sjenning  路  4Comments

stevekuznetsov picture stevekuznetsov  路  3Comments

cjwagner picture cjwagner  路  3Comments