Test-infra: Prow doesn't automatically apply language labels

Created on 8 Nov 2018  路  3Comments  路  Source: kubernetes/test-infra

This is a...

  • [ ] Feature Request
  • [x] Bug Report

Problem

Prow doesn't automatically assign language labels to PRs in k/website.

Per @cblecker in https://github.com/kubernetes/website/pull/10485#issuecomment-428312191:

Based on what I understand you're doing, you could add this label section to the language-specific OWNERS files you're already creating to delegate approval permissions, and prow would label those PRs natively. No external application required!

Using the example provided as a template, we added OWNERS files to each language subfolder:

Subsequently, Prow has not applied any language labels to PRs with content changes in the relevant directories. For example:

Proposed solution

  1. Provide guidance.

Should we be doing something differently? If we're doing something incorrectly, it's non-obvious to us.

2a. Fix Prow.

:+1:

2b. Decline to fix Prow.

We'll re-enable the kubernetes-docs-language-labeler.

/area prow
/sig docs
/kind bug
/priority important-soon

/assign @cblecker @spiffxp

areprow kinbug prioritimportant-soon sidocs

Most helpful comment

First off, you write wonderful, detailed issues, thank you. :smile:

It looks like the owners-label plugin is not enabled for kubernetes/website:

https://prow.k8s.io/plugins (look for owners-labels, click "details" for more info)
https://prow.k8s.io/plugins?repo=kubernetes%2Fwebsite (the plugin is not in the list for this repo)

I will PR a fix.

/assign

All 3 comments

First off, you write wonderful, detailed issues, thank you. :smile:

It looks like the owners-label plugin is not enabled for kubernetes/website:

https://prow.k8s.io/plugins (look for owners-labels, click "details" for more info)
https://prow.k8s.io/plugins?repo=kubernetes%2Fwebsite (the plugin is not in the list for this repo)

I will PR a fix.

/assign

Thanks @bentheelder!

Was this page helpful?
0 / 5 - 0 ratings