Test-infra: Prow GitHub Client test flakes

Created on 27 Oct 2017 · 4Comments · Source: kubernetes/test-infra

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/test-infra/5137/pull-test-infra-bazel-canary/24/#prowgithubgo_default_test

--- FAIL: TestRequestRateLimit (0.04s)
    client_test.go:63: Expected to sleep for at least a second, got 999.500002ms
FAIL

/shrug
/kind bug
/area prow

areprow kinbug ¯\_(ツ)¯

Source

BenTheElder

😄1

All 4 comments

😂 it probably should not be doing real sleep in the test

krzyzacy on 27 Oct 2017

😂 it probably should not be doing real sleep in the test

That was my first thought, I was all ready to write a bug report about how sleep is not deterministic enough for this, but actually it swaps out a reference to time.Sleep stored in a private package var (timeSleep). This is actually flaking because some time.Duration math flaked slightly below 1000ms and the test is for time.Second < slept.

BenTheElder on 27 Oct 2017

😄1

Oh whoops, that can flake. This line in the test and this line in the code.