Test-infra: prow/owners-label: owners-label should respect OwnersDirBlacklist

Created on 21 Jun 2019  路  4Comments  路  Source: kubernetes/test-infra

What happened:
Similar to https://github.com/kubernetes/test-infra/pull/12460, owners-label should respect the OwnersDirBlacklist.

What you expected to happen:
Don't label a PR based on a vendor update.

How to reproduce it (as minimally and precisely as possible):
vendor an owners file with a label statement

Please provide links to example occurrences, if any:
https://github.com/kubernetes/kube-state-metrics/pull/798

Anything else we need to know?:

areprow kinbug

Most helpful comment

If we make the repoowners package handle this when loading the OWNERS files then we won't have to update every consumer of OWNERS files.

All 4 comments

/cc @cjwagner @stevekuznetsov @nikhita

If we make the repoowners package handle this when loading the OWNERS files then we won't have to update every consumer of OWNERS files.

@nikhita: Closing this issue.

In response to this:

Fixed in https://github.com/kubernetes/test-infra/pull/12460. Tested in https://github.com/kubernetes/kubernetes/pull/80396.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

BenTheElder picture BenTheElder  路  3Comments

chaosaffe picture chaosaffe  路  3Comments

zacharysarah picture zacharysarah  路  3Comments

stevekuznetsov picture stevekuznetsov  路  4Comments

cblecker picture cblecker  路  4Comments