Tdesktop: Media key support for music playback?

[orschiro]

Dear all,

Just an idea:

What are your thoughts on adding media key support for Telegram Desktop for people to pause and resume audio file playback by pressing their media keys on their keyboard?

Tested it on Ubuntu 17.10 but it's not recognized.

[stek29]

They work on macOS and (iirc) on Windows, btw

[orschiro]

Cool! So we (just) need to add Linux MPRIS support. Anyone an idea how to
proceed?

[saeidscorp]

If I understand correctly, firstly there is a need for DBus support (as MPRIS works on top of DBus). Probably a compilation env var to add conditional support for DBus when compiling for Linux systems? Or it can have the support available on all platforms but decide to use MPRIS on runtime?

[seniorivn]

@saeidscorp there is already a dbus support in qt and also it is used here https://github.com/telegramdesktop/tdesktop/blob/0868a9f7b9e94e419542cb0d4a5d023b2fc7cb1f/Telegram/SourceFiles/platform/linux/main_window_linux.cpp#L19
for tasklist support
https://github.com/telegramdesktop/tdesktop/blob/0868a9f7b9e94e419542cb0d4a5d023b2fc7cb1f/Telegram/SourceFiles/platform/linux/main_window_linux.cpp#L355

[smaznet]

I also think MPRIS is very useful
to control music using media keys

please add this feature

[AriaMoradi]

any progress on this issue?
I would like to help with it

[stale[bot]]

Hey there!

This issue will be automatically closed in 7 days if there would be no activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

[chekoopa]

Still relevant on 2.4.4

[ilya-fedin]

any progress on this issue?

I made a try to add mpris support some time ago, but the specification requires a lot of properties, signals and methods to be implemented, not to say that the specification requires emitting PropertiesChanged which is not integrated with QtDBus. Looking to the facts that tdesktop code is really hard to understand and that I'm not interested in this feature, I stopped the work. If anyone wants to continue, there are my commits: https://github.com/ilya-fedin/tdesktop/tree/mpris.

[Aokromes]

same bug?
https://github.com/telegramdesktop/tdesktop/issues/3342

[ilya-fedin]

same bug?

No, I think this ticket could be renamed to "Add MPRIS support" to eliminate confusion