Stylus: [Firefox] Tried 3 different ways, still can't install any style

[tkosamja]

Yesterday I decided to switch from Stylish to Stylus.
First I tried to install styles from userstyles.org. I got promped if I wanted to install, said ok and nothing happened.
Then I copied the CSS, created a new style, imported the CSS and selected overwrite. I saved the style and yet again nothing happened.
After that I followed the instructions in the 5th article of the FAQ (https://add0n.com/stylus.html), I got the .json file and after importing it my mouse just kept with the load image.
What can I do?

[Mottie]

This is possibly related to the cookie or history settings. See #170.

[tkosamja]

Hi, thanks for the answer! Unfortunately it didn't work. Anything more I could try? I'm running Linux if that makes a difference

[tophf]

The new version will work regardless of cookies or remembering history, you can test it as a side-loaded extension via about:debugging page: indexeddb-fallback.zip

Have you tried this?

[tophf]

If it doesn't work, please tell us which version of Firefox you're using. This is present in the default new issue template, ~but it has an overly long comment on top which conceals what we really want to know...~ _{(now rearranged)}

[narcolepticinsomniac]

Nicely done! Tested briefly, and it appears to work brilliantly. No issues with any privacy settings in WF. We still using IndexedDB, except now with chrome.storage as a fallback?

[tophf]

Whenever possible we use IndexedDB, yes, because it's much faster.

[tkosamja]

Sorry if I'm a bit ignorant but how am I supposed to run the indexeddb-fallback.zip? I tried in about:debugging but it lead me to nothing.

[narcolepticinsomniac]

Unzip, and point to the manifest file in the unzipped folder.

[narcolepticinsomniac]

Btw, if you use WaterFox, you can actually "install from file" (not temporarily) by following the steps here.

[tkosamja]

Thanks, but still not working. I run it like I ran the stylish-export.xpi, is that right?
For further info I'm running Firefox 55.0.3 (64-bit) in Antergos.

[narcolepticinsomniac]

Debug/Load Temporary addon. Point to manifest in unzipped Stylus folder.

[tkosamja]

Yup, did that. Still nothing. It doesn't even save when I try to manually enter a style.

[narcolepticinsomniac]

Made you a screen record. If you can't follow that, I can't help you. Beyond that, the fix is already tested, so best case scenario, it'll be at least a week before we get it to AMO and they approve and push the update. You'll only be loading it temporarily, so it won't do you much good in the meantime.

Debug.zip

[tophf]

Well, you can wait for the next version release. If it won't work for you then there's nothing we can do without more technical info like the errors in the console.

[tkosamja]

Thank you both for the patience, I really appreciate it. As I said above, I pointed to the manifest file, got the add-on but it worked the same as before. I did it again with the screen record but the steps and the result were the same.
If I understood correctly the next update will fix this? If so, I guess I have to wait until there.
If not, is there more info I can give you guys to help resolve the issue?
Thanks one more time!

[tophf]

Try redownloading and reinstalling the zip above, I've updated it.
If it won't help, we can try a TeamViewer session tomorrow as I'm mildly curious what could be the issue.

[tkosamja]

Did it and nothing once more.
I'm available for a session, just hit me up.

[narcolepticinsomniac]

In FF, I have run into odd behavior with the temporary addon not loading if Stylus is already installed, though I saw no rhyme or reason as to why. Most times it has no issues, but it happened in Nightly recently IIRC. If you have your DB backed up, try uninstalling Stylus first, then install the temporary unzipped version.

[tkosamja]

Tried the temporary addon with Stylus installed, disabled and unistalling. Problem persists.

[tophf]

@tkosamja, my TeamViewer here says there's no TeamViewer running on your computer.

[tkosamja]

Try now. I'm sending you the credentials by email.

[Reeywhaar]

Had the same problem. All the styles vanished, and interface stuck on any save, and nothing was changing.
The solution for me is:

• I opened about:debugging
• Found there stylus and clicked debug
• In the console I saw TypeError: BG.cachedStyles.list is null from filters.js and I thought this was the case.
• I typed in the console BG.cachedStyles = [] hit enter and voila. Everything was fixed.

Hope this will help delevopers identify the problem.

[tophf]

@Reeywhaar, which version of Stylus were you using at that moment? Sounds like the previous one.

[Reeywhaar]

@tophf 1.1.4.1 it was. Yes, I tried different approaches, install, reinstall, install previous versions, but that didn't help.

[tophf]

1.1.4.1 supposedly should handle every possible dysfunction caused by Firefox options, including the one you quoted. Without a 100% reproducible test case I'll have to guess what I've missed in the code so not sure I'll be able to find it.

[Reeywhaar]

Well, ok, I don't know how to replicate the case now, but from my memory the state was that 'manage/filters.js:303' was trying to get length of BG.cachedStyles.list even thought it may have been null. That was throwing an exception and staggering all further code.
I don't know, but maybe initializing BG.cachedStyles.list with [] instead of null will be more adequate in background/storage.js:19.

[tophf]

I mean an exact sequence of steps needed to reproduce the issue.

but maybe initializing BG.cachedStyles.list with [] instead of null will be more adequate in background/storage.js:19.

No. The only adequate solution is to find the real reason.

[tophf]

@Reeywhaar, what's your FF version, OS? What are the FF settings for history, private mode, DOM storage, cookies? The thing is, without being able to reproduce, I can't just blindly "fix" it the way you did as it may break other things.

[tophf]

@tkosamja, is the issue fixed for you now that Stylus is updated to 1.1.4.1?

[narcolepticinsomniac]

@tophf Looks like we got yanked from the Web Store. That's pretty annoying.

[tophf]

That's an expected Kafkaesque bureaucracy thing from Google.
Actually I wonder why AMO approved the new version so quickly.

[schomery]

It is not just Stylus. My entire account got suspended this time! Seems like when an extension gets rejected several times (no matter what the reason is), they automatically suspend the account; that simple!

[narcolepticinsomniac]

That's messed up. Sorry schomery. Something changed in our code that started triggering Google's bots a while back. It'd be really nice if they clued us in as to what it is.

[tophf]

That's really annoying. I don't understand why anyone would want to submit anything to chrome webstore or, to a lesser extent, AMO (they at least send you a check log with the issues they don't like).

[schomery]

It's okay. Let's wait for a day or so to see if we get any response from Chrome support or not

[narcolepticinsomniac]

This is the third time IIRC, so it's a three strikes thing, I guess. That's still messed up, because presumably they've been getting approved upon further human review, so not only are they not bothering to tell us what's causing issues, but they're also allowing those false positives to remain on the account. Pretty useless.

[narcolepticinsomniac]

[Reeywhaar]

@tophf ok, it was ff56.0b8~9 on osx 10.12.6. The settings are pretty standard, no private mode. By DOM storage do you mean Indexed DB? All my storage setting are default for cookies, localStorage, Indexed DB, and browser.storage. The thing is that I am myself not able to reproduce the case, so it's heisenbug for me. I only know that it was between I closed/opened firefox. Maybe there was an silent update between betas, but I'm not sure. If I will able to reproduce, I let you know.

Sad to hear that you, guys, have this troubles with google.

[tophf]

@Reeywhaar, thanks. Can't test, unfortunately, because FF56 broke direct access to the background page since b6 here in Windows. I've tested Stylus 1.1.4.1 in FF55 and Nightly so without a reliable repro I would suspect a heisenbug in FF56 itself.

[the-j0k3r]

Ill add my +1 here, sometimes it just doesn't install anything, other times it does.

This bug, starting to look like the Schroedinger's cat experiment.

[narcolepticinsomniac]

@schomery I see your account is no longer suspended, but Stylus is still MIA. Any update?

[schomery]

@narcolepticinsomniac Stylus is still under review.

[tophf]

@schomery, I think it's worth releasing 1.1.4.2 with the new translations (please pull them) and a8796b0bd2799ad3ac67e3dab663c3d4bbb2a3d0, which should solve the weird failures in Firefox still being reported.

[tophf]

I mean release only on AMO.

[schomery]

locales are updated. Are we releasing at master (91daeb4a9e4a6eb6b6df2583ffab6610584befe9)?

[tophf]

Yes. I've just drafted the change log.

[tophf]

Hooray, 1.1.4.2 seems to have fixed that elusive edge case in FF.

[SirViver]

I've recently been trying to move from Stylish to Stylus (1.1.4.2) for the Firefox web extensions switch. Everything worked fine on the initial test on Firefox 56.0b12, however, now on Firefox 57.0b14 I have the exact same problem as described in this issue.

Debugging the extension shows following errors:

TypeError: BG.cachedStyles.list is null  filters.js:303:9
DOMError { name: "UnknownError", message: "The operation failed for reasons un…" }  storage.js:162:9
UnknownError  storage.js:147:18

I don't have any special cookie or history settings, and neither is IndexedDB disabled as far as I can tell.

[tophf]

@SirViver, the error source lines indicate IndexedDB is broken in your browser profile. We'll add a workaround for that. Meanwhile you can run chrome.storage.local.set({dbInChromeStorage: true}); in style manager console, disable and enable Stylus in about://addons