Signal-ios: Show alert when attempting to take photo after disabling camera permission.

[speedygonzalez1103]

Edited Bug Description (original follows)

When attempting to take a photo after disabling camera permissions there is no indication that Signal doesn't have the appropriate permissions.

Steps to reproduce

• in settings.app go to Signal and disable camera permissions
• go to a chat in signal
• press clip symbol to attach
• choose "take picture or video"

Actual result: Camera app opens, but shows black screen.

Expected result: An alert showing:

Title: Signal Doesn't Have Permission to Use Your Camera.
Description:
To take a photo, first open your systems Settings app, scroll down to Signal, and enable the camera permission.

Original report as follows

Bug description

Taking instant picture or video from within Signal chats shows photo and video app but black screen. You cannot take an instant picture or video from within Signal. White button to take picture or red button to record a video is not working. You can only press "cancel" to go back to Signal chat.

Steps to reproduce

• go to a chat in signal
• press clip symbol to attach
• choose "take picture or video"

Actual result: Camera app opens, but shows black screen. White button to take picture is not working. You can only click on "cancel" to go back to chat screen. You can swop to video but red record button is not working. Camera is generally working well. I can take a picture or video through the standard iOS camera app itself, and can attach it to a chat through "choose from photo gallery ..."
Expected result: I would expect to see camera picture to take an instant photoshot or videoshot to attach to your chat.

Screenshots

Device info

Device: iPhone 5S
iOS version: 10.0.1
Signal version: 2.4.2

Link to debug log

[michaelkirk]

Can you attach a screenshot of your privacy settings?

Go to the iOS Settings App, then scroll all the way down to Signal. It should look like this:

[speedygonzalez1103]

Thanks. My Settings were not correct. It is now working as expected.

[Trolldemorted]

Nevertheless, Signal maybe should display an error in this case.

[michaelkirk]

Nevertheless, Signal maybe should display an error in this case.

Agreed.

[michaelkirk]

solved in
https://github.com/jaropawlak/Signal-iOS/commit/4df1c45acba7354693e4f079624e4fd6676d4844