Signal-ios: SignalServiceKit refactor rendering glitches

Created on 11 Apr 2016 · 4Comments · Source: signalapp/Signal-iOS

This issue is mostly a placeholder for rendering glitches blocking release as reported by @FredericJacobs

Eg. Messages from previous thread that you were viewing, appearing in the one you are currently viewing.

Some maybe relevant commits:

large SignalServiceKit refactor: https://github.com/WhisperSystems/Signal-iOS/commit/c6d44e59e235cd8fb4b037a690a0a1c3d261f717
Big changeset to the MessageViewController: https://github.com/WhisperSystems/Signal-iOS/commit/2c83046ff667d28944038d4d459efbbecb86a81e

Source

michaelkirk

Most helpful comment

I don't really notice any glitches when viewing short or plain text threads, however as threads get longer and include more media, things get really slow, and frames start to drop.

Doing some analysis in instruments showed we're spending a lot of time building our TSInteractions. As a quick first step, I've cached them here:
https://github.com/WhisperSystems/Signal-iOS/compare/master...michaelkirk:fix-glitchy-ui?expand=1

@FredericJacobs can you see if this improves the situation that you were experiencing?

There seems to be some more low hanging optimization fruit that I will continue to attack.

michaelkirk on 12 Apr 2016

👍2

All 4 comments

I don't really notice any glitches when viewing short or plain text threads, however as threads get longer and include more media, things get really slow, and frames start to drop.

@FredericJacobs can you see if this improves the situation that you were experiencing?

There seems to be some more low hanging optimization fruit that I will continue to attack.

michaelkirk on 12 Apr 2016

👍2

No, I'm not talking about dropped frames.

When you have a few threads and switch back and forth between them, some messages from other threads might be rendered in the wrong thread.