Signal-desktop: Wrong "iPhone" link on desktop activation window

[hgascon]

• [x ] I have searched open and closed issues for duplicates

---

Bug description

When activating the Chrome desktop plugin, the "iPhone" link points to the Google Play version instead of the iOS app version.

Steps to reproduce

• Install Chrome desktop plugin
• Launch application the first time
• Pass the first window clicking on "Get Started"
• Click on the "iPhone" link
  

  Screenshots

[2-4601]

Hmm... seems like fd08297cc2a3d143d9460c8ba88756de46726a57 didn't fix it.
Now the link is just empty.

I don't really know javascript but looks like this function only expects two arguments
https://github.com/WhisperSystems/Signal-Desktop/blob/fd08297cc2a3d143d9460c8ba88756de46726a57/js/views/whisper_view.js#L60-L62

Yet it's called with three:
https://github.com/WhisperSystems/Signal-Desktop/blob/fd08297cc2a3d143d9460c8ba88756de46726a57/js/views/install_view.js#L18

Shouldn't it crash though if you do something like that?

[liliakai]

Shouldn't it crash though if you do something like that?

lol nope bc javascript lololol. :joy: :sob:

And just to confuse you further, I fixed it by changing it to 0 arguments. yolo.

[2-4601]

:scream_cat:

[smichel17]

Reasons why I'm watching this repo, in order of importance:

• @liliakai's comments (this taking the prize for best in recent memory)
• Knowing what's coming in the next signal-desktop release so I don't accidentally miss out on something
• Might be able to occasionally contribute something useful