Scratch-gui: Allow extension tiles to display both internet and bluetooth requirement icons

Created on 5 Mar 2019  路  5Comments  路  Source: LLK/scratch-gui

This is necessary because currently the connection to Scratch Link requires a working internet connection for the initial DNS lookup.

Probably we can just put the icons next to each other with a little padding, wifi first then bluetooth (curious if @carljbowman has thoughts on this)

enhancement

Most helpful comment

Thanks @evhan55 - My leaning would be towards .25rem.

All 5 comments

@ericrosenbaum @carljbowman

The current bluetooth and wifi SVGs have different inherent padding in the SVG files themselves:
screenshot 15
screenshot 16

The bluetooth SVG has good padding already without needing to add extra CSS, whereas the wifi SVGs would need some CSS. I suggest making them match so that the CSS can be uniform for all these icons. Any thoughts?

Without making any changes to CSS or the SVG files, actually, this is how things look:
Screen Shot 2019-03-12 at 10 09 42 AM

@carljbowman does that look ok to you?

Sorry to the delay on responding to this. We use a standard icon square ratio for all our icons, this helps with consistency and gives us a little space to work with to optically align icons.

Before we make updates to the icon files, I'd suggest adding some margins with CSS. Might be nice to get .25rem (4px) or .5rem (8px) between the icons. The icons do feel a little tight right now.

@carljbowman sounds good!
Do you have a preference here?

0.25rem:
Screen Shot 2019-03-12 at 10 17 47 AM

0.5rem:
Screen Shot 2019-03-12 at 10 18 32 AM

Thanks @evhan55 - My leaning would be towards .25rem.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

davidaylaian picture davidaylaian  路  4Comments

rschamp picture rschamp  路  3Comments

chrisgarrity picture chrisgarrity  路  4Comments

chrisgarrity picture chrisgarrity  路  4Comments

kyleplo picture kyleplo  路  4Comments