Scratch-gui: Multiple asset names in library inconsistent

[439bananas]

Expected Behavior

Names of multiple assets in the sprite and sound libraries should be consistent. For example, Bowtie and Bowtie1 should instead be Bowtie1 and Bowtie2. Some sprites, such as Butterfly have a space between that and the number. What happened to Hippo2? If there's only one hippo, it should say Hippo. In the sounds library, the sound titled "Movie" has a space between the number and the name. However, others have no space between the name and the identifier. In costumes, "Bell" is titled "Bell1". In the costume library, the first group of costumes for "Cassie" is actually from the sprite called "Cassie" whereas the second group of costumes for "Cassie" is actually from the sprite called "Cassie Dance".

Actual Behavior

The naming of multiple assets with the same name is inconsistent.

Steps to Reproduce

Before I continue, this also applies to costumes.

• Open any library
• Compare the names of sets of costumes with their sprites or different groups of the same sound names to another group.
• Observe

Operating System and Browser

My browser / operating system: Windows NT 10.0, Chrome 71.0.3578.98

[kyleplo]

There is also Planet2, which doesn't have a Planet1

[thisandagain]

/cc @kosiecki17 @ericrosenbaum

[439bananas]

@kyleplo Yeah, there are too many so I just gave examples.

@thisandagain Would happily go through all of the asset names and point out inconsistency.

[thisandagain]

@439bananas That would be amazing if you feel like you have the time. 🐱

[joker314]

When fixing this, for compatibility with existing projects using those costume names, old spellings in dropdowns should probably still automatically map to the correct costume.

[thisandagain]

@joker314 Luckily the libraries and saved projects are independent of each other, so we don't need to map existing projects as they will still work just fine.

[439bananas]

@439bananas That would be amazing if you feel like you have the time. 🐱

@thisandagain Sure, which files have asset names? I'm considering including spaces since it's more intuitive for younger children. I have a Minecraft server to manage, but I guess I can pause development for now.

[439bananas]

When fixing this, for compatibility with existing projects using those costume names, old spellings in dropdowns should probably still automatically map to the correct costume.

@joker314 yeah, for your information, I believe Scratch imports library assets.

[apple502j]

I'm working on it!

[439bananas]

Ayy, can you keep me updated on Discord?

On Sat, 5 Jan 2019 at 03:44, apple502j [e-mail] wrote:

I'm working on it!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/LLK/scratch-gui/issues/4218#issuecomment-451624684,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANHJ7VJufVRhDtKmr4tnQBj4RE88dbhXks5vAB-XgaJpZM4ZksyV
.

--
Sent from [email protected] [e-mail]; if
undelivered, or sent to the incorrect person, please immediately forward
the email back to the sender, and permanently delete your copy.

[2br-2b]

I'd like to help with this issue. It seems to be a good first issue, and I'm sure I can help somehow. What's the best way to help? I see there was already a rejected pull request, so what can I do to help move this issue along?