Scratch-gui: New project should reset all aspects of editor UI state

Created on 17 Oct 2018  路  7Comments  路  Source: LLK/scratch-gui

Expected Behavior

When you create or load a new file, you should be put in the code tab, with the first sprite focused, stage normal, etc.

Actual Behavior

@kchadha writes:

I was in the sound tab and created a new project and stayed in the sound tab
I had a tutorial card open, and creating a new project kept the tutorial card open
I had the video motion extension loaded and the extension remained loaded after creating a new project
Small stage mode

Operating System and Browser

Mac Chrome


Breaking this down into a few different buckets. The checked ones below aren't necessarily done, but they're no longer needing to be tracked here...

  • [x] Extensions should clean up - tracking in https://github.com/LLK/scratch-vm/issues/1731
    a. pen layer should reset (appears to be fixed)
    b. hardware should disconnect (tracking in https://github.com/LLK/scratch-vm/issues/1731)
    c. Loaded extension categories in blocks should go away - not fixed yet
  • [x] Code tab should be visible (has patch in https://github.com/LLK/scratch-gui/pull/4012)
  • [x] Tutorial card should go away (see comment by @carljbowman below)
  • [x] Small stage mode should be reset (see comment by @carljbowman below)
  • [x] Variables should reset (tracking in https://github.com/LLK/scratch-vm/issues/1758 , https://github.com/LLK/scratch-gui/issues/3427 )
  • [x] Monitors on stage should reset (tracking in https://github.com/LLK/scratch-vm/issues/1758 ; see also https://github.com/LLK/scratch-gui/issues/1812 )
bug has patch

Most helpful comment

@carljbowman commented:

I agree that the Tutorial Cards should stay open and the Stage mode should remain set. That is the 2.0's behavior. Now when it comes to which editor tab is selected, that is more dependent on the contents of the project. I think we should reset/default to the Code tab, rather than persisting the previously selected tab.

All 7 comments

@benjiwheeler @kchadha since the variable/monitors parts of this are being tracked separately, and the pen layer clearing is has-patch, do you think any other part of this should be critical?

I think the monitors resetting is critical, and the extension blocks should be checked to make sure they at least still look normal and haven't turned into red hats

Checked that the extension blocks are working, and @picklesrus has a PR_LG out for the monitors resetting, so I'm going to remove the critical label from this.

@carljbowman @kathymakes What do you think about these aspects of UI: should they reset when user creates a new project?

  1. Code tab should be visible
  2. Tutorial card should go away
  3. Small stage mode should be reset

@carljbowman commented:

I agree that the Tutorial Cards should stay open and the Stage mode should remain set. That is the 2.0's behavior. Now when it comes to which editor tab is selected, that is more dependent on the contents of the project. I think we should reset/default to the Code tab, rather than persisting the previously selected tab.

Seems like extensions are still showing up in blocks toolbox after creating new

Closing because all items in list are done or tracked elsewhere.

Was this page helpful?
0 / 5 - 0 ratings