Safe-react: Full regression - Release 3.5.0

[liliya-soroka]

The issue contains the listed of issues found during the full regression for 2.5.0 release candidate
List of issues :
- [x] Owners with added during the load safe flow name don't appear in the addressbook
Steps:
1. Load existed safe
2. add name for the owners during load safe flow
3. go to the Address book
Current result: Only loaded safe is listed in the addressbook
4. Check owners list in the settings
Current result: The entered during the safe loading names are used for the owners in the settings
Expected result: The named owners should be added to the addressbook
Chrome/MacOS

• [x] On the release branch, the Aave v2 app does not load for me. Is this a known issue?
  Also a minor and probably more of an enhancement for later: with the new cardless design we should be able to remove the grey
  (semi-transparent) background behind the legal disclaimer.
  

Background issue needs a separate task, as the component is in safe-react-components. Will be fixed here:
https://github.com/gnosis/safe-react-components/issues/118

New issues:

• [x] Editing the name of an address of an owner in the Tx list changes the name in address book and in the settings, But if you delete the entry in the address book, the name in the settings > owners' list goes back to the name it had before the editing.
  
  So:
  Have an owner in the address book
  Go to the tx list and find a tx where the target was that onwer (a send funds to that owner or tokens received by that owners works)
  Use the "..." icon to edit the name
  Check the address book and the settings to see that the name has been edited
  Go to the address book and delete the entry
  Go to the settings and see that the name of the owners is the one prior to the edition.

The name of owners in the Tx list is the one in the settings, not in the address book

UPDATE: I've check the redux and the issue is that the names of the owners and the names in the address book list they differ

• [ ] Camera remains on constantly- https://github.com/gnosis/safe-react/issues/2196

[katspaugh]

Owners with added during the load safe flow name don't appear in the addressbook

@francovenica this is the same issue as you've reported in #2122, isn't it?

Creating an entry directly in the Address Book also doesn't work.

[katspaugh]

Looks like this regression is from https://github.com/gnosis/safe-react/pull/2187/commits/9a845a203922b62a5393cfb2364f9f63dab83c59

The issue goes away when I locally restore await saveAddressBook(addressBook) as it was.

[francovenica]

@francovenica this is the same issue as you've reported in #2122, isn't it?

Yes, it was reported there already

[lukasschor]

On the release branch, the Aave v2 app does not load for me. Is this a known issue?

Also a minor and probably more of an enhancement for later: with the new cardless design we should be able to remove the grey
(semi-transparent) background behind the legal disclaimer.

[dasanra]

On the release branch, the Aave v2 app does not load for me. Is this a known issue?

Also a minor and probably more of an enhancement for later: with the new cardless design we should be able to remove the grey
(semi-transparent) background behind the legal disclaimer.

@lukasschor Aave v2 app has a domain lock, so it will only load when used under gnosis-safe.io domain. This is known and it's expected.

About the grey background of the disclaimer I agree we should leave the grey we use on the app general background.

[dasanra]

@lukasschor something like this?

[dasanra]

@lukasschor we won't solve the background issue in this release. It needs changes in safe-react-components
It's reported and will likely be ready for next release:
https://github.com/gnosis/safe-react-components/issues/118

[francovenica]

The issue reported regarding the address book is something that is already happening in production, so is not critical for this release.
The team will discuss how to deal with it, since there are other tickets that are already dealing with the address book and other storage issues.

[katspaugh]

Camera remains on constantly- #2196

Wasn't it already like this on production?

@francovenica in your gif, the URL is https://rinkeby.gnosis-safe.io.

[katspaugh]

3.5.0 has been long deployed.