Safe-react: [Backend] Research & optimize network requests for transaction tab

Created on 5 Feb 2020  路  3Comments  路  Source: gnosis/safe-react

Backend should support discussed endpoint featuring transactions filtering based on timestamps.

Note: See epic for discussion details.

Ticket in the backend repo: https://github.com/gnosis/safe-transaction-service/issues/63

Major Tech-debt 馃毀

Most helpful comment

I would call the query parameter modified_after or something more descriptive than timestamp (I got confused :grimacing: )

All 3 comments

Backend will have a new query parameter on /transactions/ and /incoming-transactions/ called timestamp, and it will receive an epoch time in milliseconds (integer). With that filter it will just return txs modified after that timestamp

For example, /transactions/?timestamp=1580989595293 will just return transactions modified after 11:46:35 UTC

What do you think @pablofullana?

I would call the query parameter modified_after or something more descriptive than timestamp (I got confused :grimacing: )

@Uxio0 @rmeissner both comments sound good to me!

Was this page helpful?
0 / 5 - 0 ratings