Safe-react: "Replaced" state for transactions that were replaced

Created on 3 Apr 2020  路  4Comments  路  Source: gnosis/safe-react

What is this about?

Currently, if there are two transactions with the same nonce (none of which is an "empty" cancellation transaction), we display the non-executed transaction as canceled if the other tx is executed. We should introduce a new status replaced for a transaction where an executed tx with the same nonce exists, which is not a cancellation transaction.

Why do we need this?

Currently, it is not possible to create two transactions with the same nonce through the interface, so this only happens in edge cases or if the user creations Multisig transactions outside of the interface. However, we might introduce an advance feature to manually set the nonce (#435), so making the distinction between canceled (where the Multisig owners voted to invalidate the tx) and replaced (where the tx is not executable because another tx already occupies this nonce) is getting more important.

@posthnikova we would need a new status label for this

Feature 馃憫 Minor

Most helpful comment

image

I propose we use Resync icon at 16px. 5D6D74 text, D4D5D3 background.

All 4 comments

I鈥檒l note that as recently as a month ago, it was possible to get this outcome through normal use of the interface. So it used to be an edge case that came up frequently.

image

I propose we use Resync icon at 16px. 5D6D74 text, D4D5D3 background.

If this gets prioritized at some point, let's please make sure to document this properly in https://github.com/gnosis/safe/wiki/Safe-transaction-states

part of layout redesign

Was this page helpful?
0 / 5 - 0 ratings

Related issues

katspaugh picture katspaugh  路  6Comments

fernandomg picture fernandomg  路  5Comments

rmeissner picture rmeissner  路  6Comments

alongoni picture alongoni  路  6Comments

lukasschor picture lukasschor  路  5Comments