Safe-react: Token icon not always displayed

[rmeissner]

Description

Sometimes it happens that a token icon is not displayed even so we have an asset for it.

when you open an app we fetch tokens from relay service, but at the same time the balance tab tries to display tokens. It doesn’t find any -> fetches the data directly from blockchain without an icon.

We can fix it in a different ways:

• The broad way - we need to improve how we fetch the data required for app to start initially. There are some improvements, because sometime we fetch data multiple times that can be fetched only once (for example last safe master contract version fetched everytime safe is fetched)
• The fast way - we just fix this bug

Screenshots

• SNX and GNO icons were available when the screenshot was taken

[mikheevm]

link to relevant discussion which touches a little bit how we load data in our app that should be required to have before we display anything: https://gnosisinc.slack.com/archives/CQB729LLF/p1592168087016500

[francovenica]

Looks good in prod. The tokens reported now have icons.
Also in the "Manage list" the vast majority of tokens have Icons (I've only seen 1 token without icon)