Safe-react: Address book empty when loading a new safe

[francovenica]

When you load a new safe in the address book the owners should be listed there. Right now the address book starts completely empty

Try to load this safe
https://safe-team-rinkeby.staging.gnosisdev.com/app/#/safes/0x8675B754342754A30A2AeF474D114d8460bca19b/address-book

[francovenica]

Update:
It seems this has to do with owners being called "Owner #N":
https://github.com/gnosis/safe-react/issues/650

Still I don't think is a good solution clean up the address book for it

[lukasschor]

650 is not implemented yet. And the address book is also empty if during creation the user gives another name to the owner(s)

[fernandomg]

650 is not implemented yet. And the address book is also empty if during creation the user gives another name to the owner(s)

588 for reference

[Agupane]

I have a question, should I start fixing this issue or it's better to just start working on #650? @lukasschor

[lukasschor]

Probably better to just go with #650. The address book being empty at start is not super critical.

[Agupane]

Couldn't reproduce the issue, could you confirm that the issue is fixed? @francovenica

[francovenica]

@Agupane Yes, this is old now. It was fixed in previous tickets. Now when you load the safe any owner who had a name set during the creation/loading of the safe will be included in the address book by default.

We can close this one