Safe-react: Test Coverage

[rmeissner]

What is this feature about? (1 sentence)

In the long run we should display a badge with code coverage in our repository. For the beginning it should be possible that we can check what our code coverage is.

Why is it needed? What is the value? For whom do we build it?

Having a decent code coverage increases trust in our interface, also this allows us to better monitor if there are sections of the code that are completely uncovered by tests. By knowing which logic is not covered by tests we can effectively prioritize the addition of new tests and plan refactorings that help improving the test coverage.

High-level overview of the feature

• Make unit and integration tests work again after typescript migration
• Use a service or tool (e.g. something like codecov.io or coverall.io) to make coverage visible
• Add badge on repo that displays coverage (once we feel comfortable)

[Agupane]

This should be an epic. We can't implement coverage right now because we currently don't have any tests working on the app. First we need to fix need, adapt them to typescript and once they run we would be able to implement coverage

[rmeissner]

If that is required you should start that. From my side tests are required and I would like to push this. We mentioned this before and it has been ignored for quite a while. If you need subtasks to finish this issue please create them.

[pablofullana]

@Agupane I've created #1194 to get rid of (the no longer required) Ganache.

Once that one is in place, let's start identifying most critical pieces of logic so we start covering them via unit tests. The non-critical logic coverage, IMHO, could be addressed by adding tests progressively upon updates or functionality extension. @rmeissner comments on this approach?