Safe-react: Modify settings transaction displays extra-owner in Confirmed/Executed component

[sche]

See the image attached.
Expected result: one owner [1/1] is displayed.

[rmeissner]

This is kind of expected (since the owners and threshold are always the current state), but this leads to other cases which might also show confusing information (e.g. when the threshold changes will it say Confirmed [1/2], even so we already executed it)?

Possible solution might be to pull the state from the block before the block of the transaction where the Safe transaction was executed.

[mikheevm]

As a solution for owners we can show only owners who confirmed for executed transactions

[mikheevm]

@rmeissner wdyt about adding safe's threshold at the time of execution to the backend?

[rmeissner]

yeah I was thinking about something like that @Uxio0 is the master of backend :P (he might even have some info like that already).

+1 to only showing who confirmed. Also here maybe the backend can tell us which confirmations were really used when executing the transaction in the end (since sometimes you have more confirmation than required).

I think currently we also always send all confirmations from the interface even if we need less (but this is a different bug)

[Uxio0]

I have stored the threshold, so I can return it or I can create a new endpoint where you can get the information of a Safe (master copy, etc.) at any point given a Safe nonce

[lukasschor]

Agree, we should only show owners that confirmed for executed transactions.

[fernandomg]

I have added a confirmationsRequired field to the txs (is already on every environment) so you can check the number of needed confirmations at some point, so no more bugged 2 of 1 confirmation when the threshold changes. There was an issue for that but I cannot find it

@Uxio0

[Uxio0]

I have added a confirmationsRequired field to the txs (is already on every environment) so you can check the number of needed confirmations at some point, so no more bugged 2 of 1 confirmation when the threshold changes. There was an issue for that but I cannot find it

This is already in every environment. It's not available for non mined txs (as it could change)

[lukasschor]

This will be addressed with the new Tx list