Safe-react: [Transaction Cancellation] Design

Created on 27 Dec 2019  Â·  10Comments  Â·  Source: gnosis/safe-react

Implement designs based on feedback from #403

Critical

Most helpful comment

Looks great!

All 10 comments

@lukasschor, this is an ongoing work.

As purposed in #403, the intention is to display the actions in a tabular form.

After some back and forth, we couldn't find a better approach to use the 'linked-list' that the current tx detail shows, so we decided to rethink the whole _votes_ section.

Having a tabular distribution with a row per user, with its possible actions (accept or cancel), and the last column to display extra information (as the 'executor' status).

The [Execute] button should appear in a latter row, under each action column, whenever it's possible.

You can see some wireframes here: https://wireframepro.mockflow.com/view/gsmultisig#/page/D44803dacf80a77d81dbf044743fe7ea7

Did you also explore options going into this direction?

Screenshot 2020-01-07 at 11 13 45
Screenshot 2020-01-07 at 11 19 14

Thanks @lukasschor. The second option looks great. We can test the different states of the app.

@lukasschor do you prefer to keep the Confirm and Reject button down below?
multisig-buton-confirm-bottom

Or can we continue with the current location near each user / wallet? Perhaps this option is clearer.
multisig-buton-confirm

Yes confirm can be up there and keep the cancel button below.

Hi @lukasschor!
Here can you see two flows:
1) Reject (with 1 confirmation petition)
Tx Details (reject flow)

2) Confirmation (whit 1 reject tx petition)
Tx Details (accept flow)

@fernandomg

1) Seeing this I would actually take back my vote for having reject at the bottom and have it also up there. Similar to how the confirm button is displayed
2) I would not call the button "Confirm Reject", this seems very confusing to me
3) There is a use-case to collect all confrmations and then execute later. However, for rejections I don't see this and would just force-execute with the last confirmation collected. What do you think?
4) I would just call the buttons "Confirm" & "Reject" instead of "Confirm tx" & "Reject tx"

3) There is a use-case to collect all confrmations and then execute later. However, for rejections I don't see this and would just force-execute with the last confirmation collected. What do you think?

@lukasschor, So we should slightly modify the Approve Transaction modal for that particular case, isn't it?

image.png

  • No checkbox for execution
  • and leave only the first sentence of the red message: Approving this transaction executes it right away.

@lukasschor. We agrupated the two buttons (Confirm and Reject) near the user wallet.
Tx Details (reject flow)
Tx Details (accept flow) - case 1

This is other case, when a user confirm first and then have two options: Execute or Reject
Tx Details (accept flow) – case 2
@fernandomg

Looks great!

Was this page helpful?
0 / 5 - 0 ratings