Refined-github: Enter a directory / file by clicking its row in the file manager

Created on 25 Jun 2020  路  9Comments  路  Source: sindresorhus/refined-github

https://github.com/sindresorhus/refined-github

image

For now you need to click on the directory name, in this case .github. But imagine it's just a. It should be possible to enter the directory just by clicking on its row, so it would be more convenient for people who have their mouse DPI set to high value.

enhancement under discussion

All 9 comments

[role="rowheader"] .js-navigation-open {
  display: inline-block;
  width: 100%;
}

Note this affect commit lists too.

This style extends the clickable area to the left side of the commit message, which IMO is acceptable (but may feel strange and hard to discover?)

I agree on the principle, but I'm hesitant to make this change this means:

  • also the commits titles and the hours will have to receive the same treatment
  • probably we need to add a full-cell background to highlight that the whole cell is clickable
  • this requires us to override the padding of each row or else the highlighting would look like this:
  • this would also mean that the whole table will become clickable and moving the mouse over it would look like a disco ball

I don't think this is worth it

I don't think we need to make the full row clickable, just the left side (from icon to commit message) would be fine (at least for me). Though I have no idea how to tell people which area is clickable in an elegant way as well.

We can do that for the commit message later. Usually commit messages are long. For a start we can do it for file names I think.

just the left side (from icon to commit message)

That sounds like what it already is, can you post a mockup of the clickable area you have in mind?

Also we can't include the icon because of edit-files-faster

We can do that for the commit message later

It's about consistency; why would the whitespace next to the filename be clickable while the whitespace next to the commit title isn't? As a user, they're feel the same.

Sorry I didn't make it clear, the icon isn't included.

image

You can check out the CSS above, which I'm currently using.

@kidonng yeah this is what it looks like with your CSS (+background)

So https://github.com/sindresorhus/refined-github/issues/3281#issuecomment-652462532 still applies.

This is not worth the CSS mess that this requires. The truncate class makes this even more difficult

Was this page helpful?
0 / 5 - 0 ratings

Related issues

shivapoudel picture shivapoudel  路  3Comments

supremebeing7 picture supremebeing7  路  3Comments

hkdobrev picture hkdobrev  路  3Comments

yakov116 picture yakov116  路  3Comments

Arcanemagus picture Arcanemagus  路  3Comments