Refined-github: Fix button for diffs without whitespace

Created on 24 Oct 2016  路  3Comments  路  Source: sindresorhus/refined-github

Since the new code reviews functionality on GitHub there has been some interface changes. GitHub changed the diff options from a drop down to a button group so the feature initially implemented in #196 stopped working.

We should change the code putting the button to make checks and modifications against the updated DOM structure.


The key to fixing this is changing how we check for the current DOM here: https://github.com/sindresorhus/refined-github/blob/b12ad0b07d24602fe400d887004540734b742500/extension/content.js#L240 and how we insert the button here: https://github.com/sindresorhus/refined-github/blob/b12ad0b07d24602fe400d887004540734b742500/extension/content.js#L269-L275

bug good first issue

All 3 comments

@anselmh @steveoh or anyone else who wants to work on this?

I鈥檒l fix that. Sorry, totally had forgotten about this.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

montogeek picture montogeek  路  3Comments

Arcanemagus picture Arcanemagus  路  3Comments

shivapoudel picture shivapoudel  路  3Comments

yakov116 picture yakov116  路  3Comments

olso picture olso  路  3Comments