Refined-github: Explore is highlighted when selecting trending

Created on 27 Sep 2017  ·  3Comments  ·  Source: sindresorhus/refined-github

image

bug help wanted

Most helpful comment

Potential problem
The explore a href has the props
data-selected-links="/explore /trending /trending/developers /integrations /integrations/feature/code /integrations/feature/collaborate /integrations/feature/ship showcases showcases_search showcases_landing /explore"

Potential solution
Remove the data-selected-links /trending from the explore link and add it to the trending link instead.

All 3 comments

Potential problem
The explore a href has the props
data-selected-links="/explore /trending /trending/developers /integrations /integrations/feature/code /integrations/feature/collaborate /integrations/feature/ship showcases showcases_search showcases_landing /explore"

Potential solution
Remove the data-selected-links /trending from the explore link and add it to the trending link instead.

Was fixed but not closed.

Thanks @busches

Yeah I think the “fixes #XXX” needs to be in the PR body, not the singular commits. I dropped it from the squashed commit to avoid yet another mention here.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mareksuscak picture mareksuscak  ·  3Comments

supremebeing7 picture supremebeing7  ·  3Comments

vanniktech picture vanniktech  ·  3Comments

alexanderadam picture alexanderadam  ·  3Comments

durka picture durka  ·  3Comments