Refined-github: Close dropdowns when they scroll out of view
From https://github.com/sindresorhus/refined-github/pull/735#issuecomment-340138827
Can use IntersectionObserver.
sindresorhus
All 3 comments
Specifically, because of my workflow when reviewing (described here: https://github.com/sindresorhus/refined-github/pull/735#issuecomment-339183475) I'd prefer not to do that.
Even though it sounds nice, clicking somewhere to close is easy and I want to keep it explicit for the review dropdown. If you this could be done for other dropdowns, but not for the review dropdown, I'm fine with it.
hkdobrev
on 28 Oct 2017
I agree it would be annoying for the review dropdown, but for the other ones, I think it's ok.
sindresorhus
on 28 Oct 2017
Hi all, I've got a working version of this new feature here: https://github.com/tom-sherman/refined-github/tree/close-out-of-view-dropdowns
It currently only works on some dropdowns, namely ones that use details elements. I'll submit a PR when I have all of the dropdowns working 馃憤
tom-sherman
on 18 Jan 2018
Related issues
pawelad
路
3Comments
hkdobrev
路
3Comments
juliocanares
路
3Comments
mareksuscak
路
3Comments
durka
路
3Comments
Most helpful comment
Specifically, because of my workflow when reviewing (described here: https://github.com/sindresorhus/refined-github/pull/735#issuecomment-339183475) I'd prefer not to do that.
Even though it sounds nice, clicking somewhere to close is easy and I want to keep it explicit for the review dropdown. If you this could be done for other dropdowns, but not for the review dropdown, I'm fine with it.