Refined-github: Sticky file header covers permalinked line

Created on 28 Dec 2017  路  3Comments  路  Source: sindresorhus/refined-github

Example

https://github.com/sindresorhus/refined-github/blob/7aad28997cdd9d6627c6620e242a17308f259897/source/content.js#L112

(navigate to this URL in a new tab)

Actual

screen shot 2017-12-28 at 11 02 04 am

Expected

screen shot 2017-12-28 at 11 02 23 am

bug help wanted

Most helpful comment

Removed some comments for legibility.


Original discussion


bfred-it

Notice: this is not a bug of RGH




sompylasar

(@)bfred-it Well, yes, technically not a bug but a consequence of the fixed top bar feature.




bfred-it

No no, the top bar is fixed by GitHub. I didn't mean that as "won't fix this non-bug" but rather "we can improve this as an enhancement" 馃憤




sompylasar

Oops for some reason I thought it's refined, or without refinement it behaved differently, otherwise I would notice the inconvenience years ago.




bfred-it

It might be a new GitHub bug, can you report it to them? They might just fix it, I can see they're manually calling their function called scrollToTargetFragment so they are interested in getting it right.




sompylasar

(@)bfred-it Yes, will do.

:heart: bfred-it




bfred-it

My super-bad. It was indeed a bug of RGH. I disabled the extension and still saw it somehow.



All 3 comments

Removed some comments for legibility.


Original discussion


bfred-it

Notice: this is not a bug of RGH




sompylasar

(@)bfred-it Well, yes, technically not a bug but a consequence of the fixed top bar feature.




bfred-it

No no, the top bar is fixed by GitHub. I didn't mean that as "won't fix this non-bug" but rather "we can improve this as an enhancement" 馃憤




sompylasar

Oops for some reason I thought it's refined, or without refinement it behaved differently, otherwise I would notice the inconvenience years ago.




bfred-it

It might be a new GitHub bug, can you report it to them? They might just fix it, I can see they're manually calling their function called scrollToTargetFragment so they are interested in getting it right.




sompylasar

(@)bfred-it Yes, will do.

:heart: bfred-it




bfred-it

My super-bad. It was indeed a bug of RGH. I disabled the extension and still saw it somehow.



I looked into fixing this via CSS and it doesn't seem to work with the padding hacks used for regular #hash linking, but because it's a table and it has that yellow background, some hacks are hard to apply. The pseudo-element hack also doesn't seem to work. I think this can only be fixed via JS.

Help wanted 馃槃

Note: this also affects markdown files: https://github.com/sindresorhus/refined-github/blob/master/readme.md#install (notice that covered Install heading)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

hkdobrev picture hkdobrev  路  3Comments

mareksuscak picture mareksuscak  路  3Comments

sindresorhus picture sindresorhus  路  3Comments

montogeek picture montogeek  路  3Comments

supremebeing7 picture supremebeing7  路  3Comments