Refined-github: Update feature `linkify-branch-refs`

Created on 25 Apr 2019  ·  6Comments  ·  Source: sindresorhus/refined-github

It's been added by GitHub, however their version doesn't add a strike-through to deleted branches. Perhaps the feature should just add a strike-through.

Testing threads:

enhancement good first issue help wanted

All 6 comments

Perhaps the feature should just add a strike-through.

👍

Ah, GitHub's own linkifier doesn't linkify the branch in the QuickPR page (https://github.com/sindresorhus/refined-github/issues/691), so maybe we should only limit the scope.

The feature linkify-branch-refs currently adds double links on PR:

image

@jerone So we have to remove unwanted one, right?

This issue is to be solved in 3 parts:

  1. Avoid linkifying the branches on PRs: done in cb8de12e
  2. Only add a strike through on deleted branches in PRs
  3. Keep linkifying “quick PR” pages: done in cb8de12e

This is now mostly solved. I'm moving back to #2274 because it's more specific.

Was this page helpful?
0 / 5 - 0 ratings